@@ -90,13 +90,15 @@ contract USTBGsmConverter is Ownable, EIP712, IGsmConverter {
9090 }
9191
9292 /// @inheritdoc IGsmConverter
93+ // TODO: maxAmount should be the amount of GHO to be received, NOT the amount of asset to be sold
9394 function sellAsset (uint256 maxAmount , address receiver ) external returns (uint256 , uint256 ) {
9495 require (maxAmount > 0 , 'INVALID_MAX_AMOUNT ' );
9596
9697 return _sellAsset (msg .sender , maxAmount, receiver);
9798 }
9899
99100 /// @inheritdoc IGsmConverter
101+ // TODO: minAmount should be the amount of USDC to be returned to user, NOT the amount of asset to buy
100102 function buyAsset (uint256 minAmount , address receiver ) external returns (uint256 , uint256 ) {
101103 require (minAmount > 0 , 'INVALID_MIN_AMOUNT ' );
102104
@@ -167,7 +169,7 @@ contract USTBGsmConverter is Ownable, EIP712, IGsmConverter {
167169
168170 /**
169171 * @notice Buys the GSM underlying asset in exchange for selling GHO, after asset redemption
170- * @param minAmount The minimum amount of the underlying asset to buy (ie BUIDL )
172+ * @param minAmount The minimum amount of the underlying asset to buy (ie USTB )
171173 * @param receiver Recipient address of the underlying asset being purchased
172174 * @return The amount of underlying asset bought, after asset redemption
173175 * @return The amount of GHO sold by the user
0 commit comments