Skip to content

test: disable rate limit #427

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Oct 11, 2024
Merged

test: disable rate limit #427

merged 4 commits into from
Oct 11, 2024

Conversation

@DhairyaSethi
Copy link
Member

@DhairyaSethi DhairyaSethi commented Oct 11, 2024

No description provided.

@height
Copy link

height bot commented Oct 11, 2024

Link Height tasks by mentioning a task ID in the pull request title or commit messages, or description and comments with the keyword link (e.g. "Link T-123").

💡Tip: You can also use "Close T-X" to automatically close a task when the pull request is merged.

miguelmtzinf
miguelmtzinf reviewed Oct 11, 2024
View reviewed changes
src/test/TestGhoCcipSteward.t.sol Outdated
);
}

function testDisableRateLimitFromNonZeroToZero() public {
Copy link
Contributor

@miguelmtzinf miguelmtzinf Oct 11, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can rename to testChangeEnabledRateLimit and test both directions: enabled -> disabled -> enabled

Copy link
Member Author

@DhairyaSethi DhairyaSethi Oct 11, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as per discussion on slack: it is currently expected behaviour that Steward cannot re-enable disabled rate limits (due to these range checks using the current value as max permittable value) and once disabled, the dao can enable rate limits again by directly interacting with the token pool

test for this behaviour added in - a194c76

miguelmtzinf
miguelmtzinf reviewed Oct 11, 2024
View reviewed changes
miguelmtzinf
miguelmtzinf reviewed Oct 11, 2024
View reviewed changes
miguelmtzinf
miguelmtzinf reviewed Oct 11, 2024
View reviewed changes
miguelmtzinf
miguelmtzinf reviewed Oct 11, 2024
View reviewed changes
@miguelmtzinf miguelmtzinf merged commit a8f654a into main Oct 11, 2024
36 checks passed
@miguelmtzinf miguelmtzinf deleted the test/disable-rate-limit branch October 11, 2024 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@miguelmtzinf miguelmtzinf miguelmtzinf approved these changes

@foodaka foodaka Awaiting requested review from foodaka foodaka is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@DhairyaSethi @miguelmtzinf