test: assertions on price comparison; cap adapter params

Author: yan-man

src/AaveV3Horizon_PriceFeed_20260404/AaveV3Horizon_PriceFeed_20260404.t.sol

@@ -5,6 +5,7 @@ import {IAaveOracle} from 'aave-v3-origin/contracts/interfaces/IAaveOracle.sol';
 import {ProtocolV3HorizonTestBase, ReserveConfig} from 'tests/utils/ProtocolV3HorizonTestBase.sol';
 import {AaveV3EthereumHorizon, AaveV3EthereumHorizonAssets} from 'aave-address-book-latest/AaveV3EthereumHorizon.sol';
 import {AaveV3Ethereum, AaveV3EthereumAssets} from 'aave-address-book-latest/AaveV3Ethereum.sol';
+import {IPriceCapAdapterStable} from 'src/interfaces/IPriceCapAdapterStable.sol';
 import {AaveV3Horizon_PriceFeed_20260404} from './AaveV3Horizon_PriceFeed_20260404.sol';
 
 /**
@@ -17,12 +18,24 @@ contract AaveV3Horizon_PriceFeed_20260404_Test is ProtocolV3HorizonTestBase {
   address internal constant OLD_RLUSD_ORACLE = AaveV3EthereumHorizonAssets.RLUSD_ORACLE;
   address internal constant OLD_USDC_ORACLE = AaveV3EthereumHorizonAssets.USDC_ORACLE;
 
-  address internal constant NEW_RLUSD_ORACLE = 0x9E7c31e9b3C76Ea759D9f7464210353862F0c957; // stable cap adapter
-  address internal constant NEW_USDC_ORACLE = 0x46f94aff8cF7DdC8557eF69f7276087b01C8f363; // stable cap adapter
+  address internal newRlusdOracle; // stable cap adapter
+  address internal newUsdcOracle; // stable cap adapter
+
+  IPriceCapAdapterStable internal rlusdAdapter;
+  IPriceCapAdapterStable internal usdcAdapter;
+
+  /// 10200 bps expressed in the 8-decimal feed precision used by the adapter.
+  int256 internal constant EXPECTED_PRICE_CAP = int256(10200) * 1e4;
 
   function setUp() public {
     vm.createSelectFork(vm.rpcUrl('mainnet'), 24852499);
     proposal = new AaveV3Horizon_PriceFeed_20260404();
+
+    newRlusdOracle = proposal.NEW_RLUSD_ORACLE();
+    newUsdcOracle = proposal.NEW_USDC_ORACLE();
+
+    rlusdAdapter = IPriceCapAdapterStable(newRlusdOracle);
+    usdcAdapter = IPriceCapAdapterStable(newUsdcOracle);
   }
 
   /**
@@ -32,8 +45,11 @@ contract AaveV3Horizon_PriceFeed_20260404_Test is ProtocolV3HorizonTestBase {
     defaultTest_v3_3('AaveV3Horizon_PriceFeed_20260404', _pool(), _executePayload);
   }
 
+  /// 1 BPS = 0.01% expressed in 1e18 precision
+  uint256 internal constant ONE_BPS = 1e14;
+
   /**
-   * @dev Verify the RLUSD oracle is updated to the CAPO adapter.
+   * @dev Verify the RLUSD oracle is updated to the cap adapter.
    */
   function test_RLUSD_PriceFeedUpdate() public {
     IAaveOracle oracle = IAaveOracle(AaveV3EthereumHorizon.ORACLE);
@@ -46,17 +62,23 @@ contract AaveV3Horizon_PriceFeed_20260404_Test is ProtocolV3HorizonTestBase {
       AaveV3EthereumAssets.RLUSD_ORACLE,
       'RLUSD oracle should differ from V3 core before'
     );
+    uint256 priceBefore = oracle.getAssetPrice(RLUSD);
 
     _executePayload();
 
     // AFTER
-    assertEq(oracle.getSourceOfAsset(RLUSD), NEW_RLUSD_ORACLE, 'RLUSD oracle after');
-    uint256 price = oracle.getAssetPrice(RLUSD);
-    assertGt(price, 0, 'RLUSD price must be positive');
+    assertEq(oracle.getSourceOfAsset(RLUSD), newRlusdOracle, 'RLUSD oracle after');
+    uint256 priceAfter = oracle.getAssetPrice(RLUSD);
+    assertApproxEqRel(
+      priceAfter,
+      priceBefore,
+      ONE_BPS,
+      'RLUSD price must be within 1 BPS of prior'
+    );
   }
 
   /**
-   * @dev Verify the USDC oracle is updated to the CAPO adapter.
+   * @dev Verify the USDC oracle is updated to the cap adapter.
    */
   function test_USDC_PriceFeedUpdate() public {
     IAaveOracle oracle = IAaveOracle(AaveV3EthereumHorizon.ORACLE);
@@ -65,16 +87,17 @@ contract AaveV3Horizon_PriceFeed_20260404_Test is ProtocolV3HorizonTestBase {
     // BEFORE
     assertEq(oracle.getSourceOfAsset(USDC), OLD_USDC_ORACLE, 'USDC oracle before');
     assertTrue(
-      oracle.getSourceOfAsset(USDC) != NEW_USDC_ORACLE,
+      oracle.getSourceOfAsset(USDC) != newUsdcOracle,
       'USDC oracle should differ from V3 core before'
     );
+    uint256 priceBefore = oracle.getAssetPrice(USDC);
 
     _executePayload();
 
     // AFTER
-    assertEq(oracle.getSourceOfAsset(USDC), NEW_USDC_ORACLE, 'USDC oracle after');
-    uint256 price = oracle.getAssetPrice(USDC);
-    assertGt(price, 0, 'USDC price must be positive');
+    assertEq(oracle.getSourceOfAsset(USDC), newUsdcOracle, 'USDC oracle after');
+    uint256 priceAfter = oracle.getAssetPrice(USDC);
+    assertApproxEqRel(priceAfter, priceBefore, ONE_BPS, 'USDC price must be within 1 BPS of prior');
   }
 
   /// @dev Verify GHO oracle already matches V3 core (only other stablecoin within both pools).
@@ -87,18 +110,48 @@ contract AaveV3Horizon_PriceFeed_20260404_Test is ProtocolV3HorizonTestBase {
     );
   }
 
-  /// @dev Override expected price feeds so the snapshot validator accepts the new oracles.
-  function _expectedPriceFeed(address underlying) internal pure override returns (address) {
+  /// @dev RLUSD stable cap adapter constructor params.
+  function test_RLUSD_AdapterParams() public view {
+    assertEq(
+      rlusdAdapter.ACL_MANAGER(),
+      address(AaveV3EthereumHorizon.ACL_MANAGER),
+      'RLUSD adapter ACL_MANAGER mismatch'
+    );
+    assertEq(
+      rlusdAdapter.ASSET_TO_USD_AGGREGATOR(),
+      AaveV3EthereumHorizonAssets.RLUSD_ORACLE,
+      'RLUSD adapter underlying must be Horizon non-SVR Chainlink feed'
+    );
+    assertEq(rlusdAdapter.getPriceCap(), EXPECTED_PRICE_CAP, 'RLUSD adapter price cap mismatch');
+  }
+
+  /// @dev USDC stable cap adapter constructor params.
+  function test_USDC_AdapterParams() public view {
+    assertEq(
+      usdcAdapter.ACL_MANAGER(),
+      address(AaveV3EthereumHorizon.ACL_MANAGER),
+      'USDC adapter ACL_MANAGER mismatch'
+    );
+    assertEq(
+      usdcAdapter.ASSET_TO_USD_AGGREGATOR(),
+      AaveV3EthereumHorizonAssets.USDC_ORACLE,
+      'USDC adapter underlying must be Horizon non-SVR Chainlink feed'
+    );
+    assertEq(usdcAdapter.getPriceCap(), EXPECTED_PRICE_CAP, 'USDC adapter price cap mismatch');
+  }
+
+  function _executePayload() internal {
+    _executeHorizonPayload(address(proposal));
+  }
+
+  /// @dev Override expected price feeds so the snapshot validator in defaultTest accepts the new oracles.
+  function _expectedPriceFeed(address underlying) internal override returns (address) {
     if (underlying == AaveV3EthereumHorizonAssets.RLUSD_UNDERLYING) {
-      return NEW_RLUSD_ORACLE;
+      return newRlusdOracle;
     }
     if (underlying == AaveV3EthereumHorizonAssets.USDC_UNDERLYING) {
-      return NEW_USDC_ORACLE;
+      return newUsdcOracle;
     }
     return super._expectedPriceFeed(underlying);
   }
-
-  function _executePayload() internal {
-    _executeHorizonPayload(address(proposal));
-  }
 }

src/interfaces/IPriceCapAdapterStable.sol

@@ -0,0 +1,8 @@
+// SPDX-License-Identifier: MIT
+pragma solidity ^0.8.0;
+
+interface IPriceCapAdapterStable {
+  function ACL_MANAGER() external view returns (address);
+  function ASSET_TO_USD_AGGREGATOR() external view returns (address);
+  function getPriceCap() external view returns (int256);
+}