Made testExtractZip64_LargeFile more rigorous

Author: abbeycode

Tests/ExtractFilesTests.m

@@ -237,11 +237,13 @@ - (void)testExtractFiles_Aces
 
 - (void)testExtractZip64_LargeFile
 {
-    NSURL *fourGigFileURL = [self emptyTextFileOfLength:4 * pow(2.0, 30.0)];
-    NSURL *smallFileURL = [self emptyTextFileOfLength:4];
+    NSArray<NSURL*> *urls = @[
+                              [self emptyTextFileOfLength:4 * pow(2.0, 30.0)],
+                              self.unicodeFileURLs[@"Test File Ⓐ.txt"]
+                              ];
 
     NSError *error = nil;
-    NSURL *url = [self archiveWithFiles:@[fourGigFileURL, smallFileURL]];
+    NSURL *url = [self archiveWithFiles:urls];
     UZKArchive *archive = [[UZKArchive alloc] initWithURL:url error:&error];
 
     XCTAssertNil(error, @"Failed to init archive");
@@ -263,6 +265,20 @@ - (void)testExtractZip64_LargeFile
 
     XCTAssertTrue(success, @"Extract large Zip64 archive failed");
     XCTAssertNil(error, @"Error extracting large Zip64 archive");
+    
+    NSArray *expectedCRCs = @[
+                              @([self crcOfFile:urls[0]]),
+                              @([self crcOfFile:urls[1]])
+                              ];
+    
+    NSArray *actualCRCs = @[
+                            @([self crcOfFile:[extractURL URLByAppendingPathComponent:urls[0].lastPathComponent]]),
+                            @([self crcOfFile:[extractURL URLByAppendingPathComponent:urls[1].lastPathComponent]]),
+                              ];
+    
+    for (NSUInteger i = 0; i < expectedCRCs.count; i++) {
+        XCTAssertEqualObjects(expectedCRCs[i], actualCRCs[i], @"CRCs didn't match");
+    }
 }
 
 - (void)testExtractZip64_ManyFiles

Tests/UZKArchiveTestCase.h

@@ -38,6 +38,7 @@
 - (BOOL)extractArchive:(NSURL *)url password:(NSString *)password;
 - (NSURL *)largeArchive;
 
+- (NSUInteger)crcOfFile:(NSURL *)url;
 - (NSUInteger)crcOfTestFile:(NSString *)filename;
 
 @end

Tests/UZKArchiveTestCase.m

@@ -201,8 +201,11 @@ - (NSURL *)emptyTextFileOfLength:(NSUInteger)fileSize
                                                                  error:&error];
     XCTAssertNil(error, @"Error creating file handle for URL: %@", resultURL);
 
+    NSData *emptyByte = [@"\x01" dataUsingEncoding:NSUTF8StringEncoding];
+    
+    [fileHandle writeData:emptyByte];
     [fileHandle seekToFileOffset:fileSize];
-    [fileHandle writeData:(NSData *__nonnull)[@"\x00" dataUsingEncoding:NSUTF8StringEncoding]];
+    [fileHandle writeData:emptyByte];
     [fileHandle closeFile];
 
     return resultURL;
@@ -308,11 +311,16 @@ - (NSURL *)largeArchive
     return largeArchiveURL;
 }
 
+- (NSUInteger)crcOfFile:(NSURL *)url
+{
+    NSData *fileContents = [[NSFileManager defaultManager] contentsAtPath:url.path];
+    return crc32(0, fileContents.bytes, (uInt)fileContents.length);
+}
+
 - (NSUInteger)crcOfTestFile:(NSString *)filename
 {
     NSURL *fileURL = [self urlOfTestFile:filename];
-    NSData *fileContents = [[NSFileManager defaultManager] contentsAtPath:fileURL.path];
-    return crc32(0, fileContents.bytes, (uInt)fileContents.length);
+    return [self crcOfFile:fileURL];
 }