Skip to content

[minty action] String response from /token causes action to silently output an empty token #256

Description

@lock14

TL;DR

Problem Description

When using uses: abcxyz/github-token-minter/.github/actions/minty@main, the step completes successfully (exit code 0), but:

  1. The step output ${{ steps.<id>.outputs.token }} is empty / blank.
  2. The environment variable MINTY_TOKEN is not set.
  3. The step logs a warning: ##[warning]Can't add secret mask for empty string in ##[add-mask] command.
  4. Downstream steps fail because no token was passed to them.

Root Cause

In .github/actions/minty/main.js:

const responseText = await response.text();

if (response.ok) {
  try {
    // expecting `{ "token": "TOKEN" }` format
    const resp = JSON.parse(responseText);
    core.setSecret(resp.token);
    core.setOutput('token', resp.token);
    core.saveState('MINTY_TOKEN', resp.token);
  } catch (err) {
    const token = responseText;
    core.setSecret(token);
    core.setOutput('token', token);
    core.exportVariable('MINTY_TOKEN', token);
    core.saveState('MINTY_TOKEN', token);
  }
}

When /token returns a raw or JSON-quoted token string (e.g., "ghs_1234567890abcdef"):

  1. JSON.parse("\"ghs_1234567890abcdef\"") succeeds without throwing, returning the primitive string "ghs_1234567890abcdef".
  2. resp.token evaluates to undefined because JavaScript strings do not have a .token property.
  3. core.setOutput('token', undefined) silently sets the output to an empty string.
  4. Because JSON.parse did not throw an error, the catch block (intended for raw strings) is never executed.

Proposed Solution

Check if resp is an object with a .token property or a string before setting the output:

let token = responseText;
try {
  const resp = JSON.parse(responseText);
  if (resp && typeof resp === 'object' && resp.token) {
    token = resp.token;
  } else if (typeof resp === 'string') {
    token = resp;
  }
} catch {
  // Response was not JSON, use responseText as raw token string
}

core.setSecret(token);
core.setOutput('token', token);
core.exportVariable('MINTY_TOKEN', token);
core.saveState('MINTY_TOKEN', token);

Expected behavior

No response

Observed behavior

No response

Environment Details

internal instance.

Additional information

No response

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions