Merge pull request #49 from abdel-17/fix-copy

Fix Copy

Author: abdel-17

.github/workflows/ci.yml

@@ -12,7 +12,7 @@ concurrency:
 
 jobs:
   check:
-    name: Check
+    name: Svelte Check
     runs-on: ubuntu-latest
     steps:
       - uses: actions/checkout@v4
@@ -28,7 +28,8 @@ jobs:
       - name: Build
         run: pnpm build
 
-      - run: pnpm check
+      - name: Run Svelte Check
+        run: pnpm check
 
   # TODO: re-enable tests in CI
   # test:
@@ -51,7 +52,7 @@ jobs:
   #     - run: pnpm test
 
   lint:
-    name: Lint
+    name: Formatting
     runs-on: ubuntu-latest
     steps:
       - uses: actions/checkout@v4
@@ -67,4 +68,5 @@ jobs:
       - name: Build
         run: pnpm build
 
-      - run: pnpm lint
+      - name: Run Prettier
+        run: pnpm format:check

eslint.config.js

@@ -9,17 +9,11 @@
 		"build:preview": "pnpm build:packages && pnpm -F preview build",
 		"check": "pnpm --parallel check",
 		"format": "pnpm --parallel format",
-		"lint": "pnpm --parallel format:check && eslint ."
+		"format:check": "pnpm --parallel format:check"
 	},
 	"devDependencies": {
 		"@changesets/cli": "^2.28.1",
-		"@eslint/js": "^9.21.0",
-		"eslint": "^9.21.0",
-		"eslint-plugin-svelte": "^3.0.2",
-		"globals": "^16.0.0",
-		"playwright": "^1.50.1",
-		"typescript": "^5.8.2",
-		"typescript-eslint": "^8.26.0"
+		"playwright": "^1.50.1"
 	},
 	"pnpm": {
 		"onlyBuiltDependencies": [
@@ -28,4 +22,4 @@
 		]
 	},
 	"packageManager": "pnpm@10.4.1+sha512.c753b6c3ad7afa13af388fa6d808035a008e30ea9993f58c6663e2bc5ff21679aa834db094987129aa4d488b86df57f7b634981b2f827cdcacc698cc0cfb88af"
-}
+}

package.json

@@ -487,18 +487,23 @@ export function createTreeState<TData extends FileTreeNodeData>({
 	}
 
 	function copyNode(node: FileTreeNode<TData>): FileTreeNode<TData> {
+		if (DEV && Object.getPrototypeOf(node.data) !== Object.prototype) {
+			throw new Error("Expected the data property to be a POJO");
+		}
+
 		const id = generateCopyId();
+		const data = $state.snapshot(node.data) as TData;
 		switch (node.type) {
 			case "file": {
 				return new FileNode({
 					id,
-					data: structuredClone(node.data),
+					data,
 				});
 			}
 			case "folder": {
 				return new FolderNode({
 					id,
-					data: structuredClone(node.data),
+					data,
 					children: node.children.map(copyNode),
 				});
 			}

packages/svelte-file-tree/src/lib/components/Tree/state.svelte.ts

@@ -129,7 +129,6 @@
 				const navigate = down ? treeState.getNextItem : treeState.getPreviousItem;
 				const shouldSelectMultiple = event.shiftKey && isControlOrMeta(event);
 				const maxScrollDistance = Math.min(
-					// eslint-disable-next-line @typescript-eslint/no-non-null-assertion
 					document.getElementById(treeState.id())!.clientHeight,
 					document.documentElement.clientHeight,
 				);
@@ -201,14 +200,12 @@
 				break;
 			}
 			case "End": {
-				// eslint-disable-next-line @typescript-eslint/no-non-null-assertion
 				let last = treeState.tree().children.at(-1)!;
 				while (
 					last.type === "folder" &&
 					treeState.expandedIds().has(last.id) &&
 					last.children.length !== 0
 				) {
-					// eslint-disable-next-line @typescript-eslint/no-non-null-assertion
 					last = last.children.at(-1)!;
 				}
 

packages/svelte-file-tree/src/lib/components/TreeItem/TreeItem.svelte

@@ -2,7 +2,6 @@ import type { EventHandler } from "svelte/elements";
 
 // https://developer.mozilla.org/en-US/docs/Web/API/Navigator/platform#examples
 export function isControlOrMeta(event: KeyboardEvent | MouseEvent): boolean {
-	// eslint-disable-next-line @typescript-eslint/no-deprecated
 	if (navigator.platform.startsWith("Mac") || navigator.platform === "iPhone") {
 		return event.metaKey;
 	}

packages/svelte-file-tree/src/lib/internal/helpers.ts

@@ -8,11 +8,7 @@ export default {
 			config(config) {
 				return {
 					...config,
-					include: [
-						// eslint-disable-next-line @typescript-eslint/no-unsafe-assignment
-						...config.include,
-						"../vitest.workspace.ts",
-					],
+					include: [...config.include, "../vitest.workspace.ts"],
 				};
 			},
 		},