feat: support conversation filter object on conversations select elements#346
Merged
Merged
Conversation
…ents Slack's conversation_filter composition object lets callers restrict which conversation types appear in a conversations_select picker — e.g. only public/private channels, excluding DMs and bot users. This is needed downstream to prevent users from selecting incorrect conversations. A separate SlackConversationFilterInclude enum is introduced because the filter API uses "public"/"private" while the existing SlackConversationType serializes to "public_channel"/"private_channel".
Owner
|
Hey, thanks for the contributions, the changes looks good, have you tested them with a real Slack workspace? |
abdolence
approved these changes
Mar 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Slack's conversation_filter composition object lets callers restrict which conversation types appear in a conversations_select picker — e.g. only public/private channels, excluding DMs and bot users. This is needed downstream to prevent users from selecting incorrect conversations.
A separate
SlackConversationFilterIncludeenum is introduced because the filter API uses"public"/"private"while the existingSlackConversationTypeserializes to"public_channel"/"private_channel".Disclaimer: I am not an experienced Rust dev and this is generated with Claude help. I am willing to improve the PR if necessary.