refactor: improve CLOB processing with BufferedReader and streamline error handling

Author: SamuelQuetin

src/main/java/fr/abes/sudoc/service/NoticeService.java

@@ -11,11 +11,13 @@
 import lombok.extern.slf4j.Slf4j;
 import org.springframework.stereotype.Service;
 
+import java.io.BufferedReader;
 import java.io.IOException;
 import java.io.Reader;
 import java.sql.Clob;
 import java.sql.SQLException;
 import java.util.*;
+import java.util.stream.Collectors;
 
 @Service
 @Slf4j
@@ -38,30 +40,27 @@ public NoticeXml getNoticeByPpn(String ppn) throws IllegalPpnException, IOExcept
             throw new IllegalPpnException("Le PPN ne peut pas être null");
         //Optional<NoticesBibio> noticeOpt = this.noticesBibioRepository.findByPpn(ppn);
         Optional<NoticesBibio> noticeOpt = baseXmlFunctionsCaller.findByPpn(ppn);
-        if (noticeOpt.isPresent()) {
-            Clob clob = noticeOpt.get().getDataXml();
-
-            try (Reader reader = clob.getCharacterStream()){
-                return xmlMapper.readValue(reader, NoticeXml.class);
-            } catch (SQLException e) {
-                log.error(e.getMessage());
-            } finally {
-                try {
-                    clob.free();
-                } catch (SQLException e) {
-                    log.error(e.getMessage());
-                }
-            }
+        if (noticeOpt.isEmpty()) {
+            return null;
         }
-
-        /*if (noticeOpt.isPresent()) {
+        Clob clob = noticeOpt.get().getDataXml();
+        String xmlString = null;
+        
+        try (Reader reader = clob.getCharacterStream()){
+            xmlString = new BufferedReader(reader)
+                    .lines()
+                    .collect(Collectors.joining("\n"));
+        } catch (SQLException e) {
+            log.error(e.getMessage());
+        } finally {
             try {
-                return xmlMapper.readValue(noticeOpt.get().getDataXml().getCharacterStream(), NoticeXml.class);
+                clob.free();
             } catch (SQLException e) {
                 log.error(e.getMessage());
             }
-        }*/
-        return null;
+        }
+        
+        return (xmlString != null) ? xmlMapper.readValue(xmlString, NoticeXml.class) : null;
     }
 
     public List<String> getEquivalentElectronique(NoticeXml notice) throws IOException, IllegalPpnException, ZoneNotFoundException {