Merge pull request containers#1838 from engelmi/improve-no-model-file-error-message

Added error message for GGUF not found and safetensor unsupported

Author: rhatdan

ramalama/cli.py

@@ -28,7 +28,7 @@
 from ramalama.common import accel_image, get_accel, perror
 from ramalama.config import CONFIG, coerce_to_bool, load_file_config
 from ramalama.logger import configure_logger, logger
-from ramalama.model import MODEL_TYPES, trim_model_name
+from ramalama.model import MODEL_TYPES, NoGGUFModelFileFound, SafetensorModelNotSupported, trim_model_name
 from ramalama.model_factory import ModelFactory, New
 from ramalama.model_inspect.error import ParseError
 from ramalama.model_store.global_store import GlobalModelStore
@@ -1256,6 +1256,8 @@ def eprint(e, exit_code):
         perror("Error: " + str(e).strip("'\""))
         sys.exit(exit_code)
 
+    parser: ArgumentParserWithDefaults
+    args: argparse.Namespace
     try:
         parser, args = init_cli()
         try:
@@ -1293,3 +1295,13 @@ def eprint(e, exit_code):
         eprint(e, errno.EIO)
     except ParseError as e:
         eprint(f"Failed to parse model: {e}", errno.EINVAL)
+    except SafetensorModelNotSupported:
+        eprint(
+            f"""Safetensor models are not supported. Please convert it to GGUF via:
+$ ramalama convert --gguf=<quantization> {args.model} <oci-name>
+$ ramalama run <oci-name>
+""",
+            errno.EMEDIUMTYPE,
+        )
+    except NoGGUFModelFileFound:
+        eprint(f"No GGUF model file found for downloaded model '{args.model}'", errno.ENOMEDIUM)

ramalama/model.py

@@ -55,14 +55,22 @@
 $(error)s"""
 
 
+class NoGGUFModelFileFound(Exception):
+    pass
+
+
+class SafetensorModelNotSupported(Exception):
+    pass
+
+
 class NoRefFileFound(Exception):
     def __init__(self, model: str, *args):
         super().__init__(*args)
 
         self.model = model
 
     def __str__(self):
-        return f"No ref file or models found for '{self.model}'. Please pull model."
+        return f"No ref file found for '{self.model}'. Please pull model."
 
 
 def trim_model_name(model):
@@ -201,8 +209,12 @@ def _get_entry_model_path(self, use_container: bool, should_generate: bool, dry_
                 return f"oci://{self.model}"
 
         ref_file = self.model_store.get_ref_file(self.model_tag)
-        if ref_file is None or not ref_file.model_files:
+        if ref_file is None:
             raise NoRefFileFound(self.model)
+        if not ref_file.model_files:
+            if any(file.name.endswith(".safetensors") for file in ref_file.files):
+                raise SafetensorModelNotSupported()
+            raise NoGGUFModelFileFound()
 
         # Use the first model file
         if is_split_file_model(self.model_name):