all: Drop outdated TODOs (#383)

[skip changelog]: no user facing changes

Author: abhinav

branch_submit.go

@@ -144,7 +144,6 @@ func (cmd *branchSubmitCmd) run(
 			log.Errorf("  gs branch restack --branch=%s", cmd.Branch)
 			log.Errorf("Or, try again with --force to submit anyway.")
 			return errors.New("refusing to submit outdated branch")
-			// TODO: this can be made optional with a --force or a prompt.
 		}
 	}
 

branch_untrack.go

@@ -39,7 +39,6 @@ func (cmd *branchUntrackCmd) Run(ctx context.Context, log *log.Logger, opts *glo
 		}
 	}
 
-	// TODO: prompt for confirmation?
 	if err := svc.ForgetBranch(ctx, cmd.Branch); err != nil {
 		if errors.Is(err, state.ErrNotExist) {
 			return errors.New("branch not tracked")

dumpmd.go

@@ -109,7 +109,6 @@ func (cmd *cliDumper) dump(app *kong.Application) {
 		cmdByGroup[key] = append(cmdByGroup[key], subcmd)
 	}
 
-	// TODO: separate "inspect" and "dump" steps
 	cmd.println("```")
 	cmd.println("gs" + app.Summary())
 	cmd.println("```")

internal/forge/github/change_meta.go

@@ -20,7 +20,7 @@ var _ forge.ChangeMetadata = (*PRMetadata)(nil)
 
 // ForgeID reports the forge ID that owns this metadata.
 func (*PRMetadata) ForgeID() string {
-	return "github" // TODO: const
+	return "github"
 }
 
 // ChangeID reports the change ID of the pull request.

internal/forge/shamhub/change_meta.go

@@ -17,7 +17,7 @@ type ChangeMetadata struct {
 
 // ForgeID reports the forge ID that owns this metadata.
 func (*ChangeMetadata) ForgeID() string {
-	return "shamhub" // TODO: const
+	return "shamhub"
 }
 
 // ChangeID reports the change ID of the change.

internal/spice/restack.go

@@ -86,8 +86,6 @@ func (s *Service) Restack(ctx context.Context, name string) (*RestackResponse, e
 		Quiet:     true,
 	}); err != nil {
 		return nil, fmt.Errorf("rebase: %w", err)
-		// TODO: detect conflicts in rebase,
-		// print message about "gs rebase continue"
 	}
 
 	err = s.store.UpdateBranch(ctx, &state.UpdateRequest{

internal/spice/template.go

@@ -22,7 +22,6 @@ func (s *Service) ListChangeTemplates(
 	remoteName string,
 	fr forge.Repository,
 ) ([]*forge.ChangeTemplate, error) {
-	// TODO: Should Repo be injected?
 	pathSet := make(map[string]struct{})
 	for _, p := range fr.Forge().ChangeTemplatePaths() {
 		pathSet[p] = struct{}{}

repo_sync.go

@@ -407,11 +407,5 @@ func (cmd *repoSyncCmd) deleteMergedBranches(
 		}
 	}
 
-	// TODO:
-	// If --restack is set, restack the affected branches
-	// (or restack just the branches in this stack?)
-	// For this, we need the Delete operation to report the affected
-	// branches, which means it has to be refactored into a spice-level
-	// operation first.
 	return nil
 }