Fixed validation checks for mutable-messages flag as per review comments

Author: sacOO7

src/commands/apps/channel-rules/index.ts

@@ -9,7 +9,7 @@ export default class ChannelRulesIndexCommand extends BaseTopicCommand {
   static examples = [
     "ably apps channel-rules list",
     'ably apps channel-rules create --name "chat" --persisted',
-    'ably apps channel-rules update --name "chat" --mutable-messages',
+    "ably apps channel-rules update chat --mutable-messages",
     "ably apps channel-rules update chat --push-enabled",
     "ably apps channel-rules delete chat",
   ];

src/commands/apps/channel-rules/update.ts

@@ -139,8 +139,11 @@ export default class ChannelRulesUpdateCommand extends ControlBaseCommand {
       const updateData: Record<string, boolean | number | string | undefined> =
         {};
 
-      // Validation for mutable-messages flag
-      if (flags.persisted === false && flags["mutable-messages"]) {
+      // Validation for mutable-messages flag, checks with supplied/existing mutableMessages flag
+      if (
+        flags.persisted === false &&
+        (flags["mutable-messages"] || namespace.mutableMessages)
+      ) {
         const errorMsg =
           "Cannot disable persistence when mutable messages is enabled. Mutable messages requires message persistence.";
         if (this.shouldOutputJson(flags)) {
@@ -164,14 +167,18 @@ export default class ChannelRulesUpdateCommand extends ControlBaseCommand {
         updateData.persisted = flags.persisted;
       }
 
-      if (flags["mutable-messages"]) {
+      if (flags["mutable-messages"] !== undefined) {
         updateData.mutableMessages = flags["mutable-messages"];
-        updateData.persisted = true;
-        this.logToStderr(
-          chalk.yellow(
-            "Warning: Message persistence is automatically enabled when mutable messages is enabled.",
-          ),
-        );
+        if (flags["mutable-messages"]) {
+          updateData.persisted = true;
+          if (!this.shouldOutputJson(flags)) {
+            this.logToStderr(
+              chalk.yellow(
+                "Warning: Message persistence is automatically enabled when mutable messages is enabled.",
+              ),
+            );
+          }
+        }
       }
 
       if (flags["push-enabled"] !== undefined) {