Commit 0cb7655
committed
Add support for ably-cli in agents header
Note that describing the ably-cli as a wrapper is arguably not correct, it's an application or perhaps a tool, but adding support for a new type is probably a lot of work, and at this stage, has limited value given we simply want a way to track ably-cli usage. The reason it's not correct is in the context of the data plane, ably-cli is not providing an API to end users, and wrapping functionality in an SDK, it is just a tool or app consuming. When it's calling the control plane, then it's not really an SDK as it's just a tool calling the API directly, and it's not a wrapper as it's not wrapping anything. If I categorised ably-cli as an SDK, then we'd also have the problem that the underlying SDK would not be logged as I believe only one SDK value is supported in most reports.
This commit also adds instructions for future people who want to make changes to agents to make them aware that agents are duplicated in our analytics pipeline processing.1 parent 3fc3012 commit 0cb7655
2 files changed
+12
-0
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
93 | 93 | | |
94 | 94 | | |
95 | 95 | | |
| 96 | + | |
96 | 97 | | |
97 | 98 | | |
98 | 99 | | |
| |||
144 | 145 | | |
145 | 146 | | |
146 | 147 | | |
| 148 | + | |
| 149 | + | |
147 | 150 | | |
148 | 151 | | |
149 | 152 | | |
| |||
154 | 157 | | |
155 | 158 | | |
156 | 159 | | |
| 160 | + | |
| 161 | + | |
| 162 | + | |
| 163 | + | |
157 | 164 | | |
158 | 165 | | |
159 | 166 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
364 | 364 | | |
365 | 365 | | |
366 | 366 | | |
| 367 | + | |
| 368 | + | |
| 369 | + | |
| 370 | + | |
| 371 | + | |
367 | 372 | | |
368 | 373 | | |
369 | 374 | | |
| |||
0 commit comments