Skip to content

Commit 5d7a02f

Browse files
committed
[ECO-4567] Updated tests to use JAssert.DeepEquals instead of JToken.DeepEquals
1 parent 39a2c58 commit 5d7a02f

File tree

4 files changed

+23
-8
lines changed

4 files changed

+23
-8
lines changed

src/IO.Ably.Tests.Shared/MsgPackMessageSerializerTests.cs

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,7 @@
33
using System.Linq;
44
using FluentAssertions;
55
using IO.Ably.MessageEncoders;
6+
using IO.Ably.Tests.Shared.Helpers;
67
using IO.Ably.Types;
78
using MessagePack;
89
using Newtonsoft.Json;
@@ -700,14 +701,14 @@ public void TestMsgpackDecoding(string testName, MsgpackTestFixture fixture)
700701
// For JSON objects, compare as JToken for proper equality
701702
var expectedJson = JsonConvert.SerializeObject(fixture.Data);
702703
var actualJson = JsonConvert.SerializeObject(decodedMsg.Data);
703-
JToken.DeepEquals(JToken.Parse(expectedJson), JToken.Parse(actualJson)).Should().BeTrue();
704+
JAssert.DeepEquals(JToken.Parse(expectedJson), JToken.Parse(actualJson), Output).Should().BeTrue();
704705
break;
705706

706707
case "jsonArray":
707708
// For JSON arrays, compare as JToken for proper equality
708709
var expectedArrayJson = JsonConvert.SerializeObject(fixture.Data);
709710
var actualArrayJson = JsonConvert.SerializeObject(decodedMsg.Data);
710-
JToken.DeepEquals(JToken.Parse(expectedArrayJson), JToken.Parse(actualArrayJson)).Should().BeTrue();
711+
JAssert.DeepEquals(JToken.Parse(expectedArrayJson), JToken.Parse(actualArrayJson), Output).Should().BeTrue();
711712
break;
712713

713714
default:

src/IO.Ably.Tests.Shared/Realtime/ChannelSandboxSpecs.cs

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,7 @@
1111
using IO.Ably.Realtime;
1212
using IO.Ably.Tests.Extensions;
1313
using IO.Ably.Tests.Infrastructure;
14+
using IO.Ably.Tests.Shared.Helpers;
1415
using IO.Ably.Types;
1516
using Newtonsoft.Json.Linq;
1617
using Xunit;
@@ -910,7 +911,7 @@ public async Task ShouldPublishAndReceiveFixtureData(Protocol protocol, JObject
910911
}
911912
else if (encoding == "json")
912913
{
913-
JToken.DeepEquals((JToken)lastMessage.Data, (JToken)decodedData).Should().BeTrue("Item number {0} data does not match decoded data", count);
914+
JAssert.DeepEquals((JToken)lastMessage.Data, (JToken)decodedData, Output).Should().BeTrue("Item number {0} data does not match decoded data", count);
914915
}
915916
else
916917
{

src/IO.Ably.Tests.Shared/Rest/ChannelSandboxSpecs.cs

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,7 @@
1111
using Newtonsoft.Json.Linq;
1212
using Xunit;
1313
using Xunit.Abstractions;
14+
using IO.Ably.Tests.Shared.Helpers;
1415

1516
namespace IO.Ably.Tests.Rest
1617
{
@@ -368,7 +369,7 @@ public async Task CanPublishAMessageAndRetrieveIt128(Protocol protocol)
368369
}
369370
else if (encoding == "json")
370371
{
371-
JToken.DeepEquals((JToken)message.Data, (JToken)decodedData).Should().BeTrue("Item number {0} data does not match decoded data", count);
372+
JAssert.DeepEquals((JToken)message.Data, (JToken)decodedData, Output).Should().BeTrue("Item number {0} data does not match decoded data", count);
372373
}
373374
else
374375
{
@@ -408,7 +409,7 @@ public async Task CanPublishAMessageAndRetrieveIt256(Protocol protocol)
408409
}
409410
else if (encoding == "json")
410411
{
411-
JToken.DeepEquals((JToken)message.Data, (JToken)decodedData).Should().BeTrue("Item number {0} data does not match decoded data", count);
412+
JAssert.DeepEquals((JToken)message.Data, (JToken)decodedData, Output).Should().BeTrue("Item number {0} data does not match decoded data", count);
412413
}
413414
else
414415
{

src/IO.Ably.Tests.Shared/Rest/PresenceSandboxSpecs.cs

Lines changed: 15 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,7 @@
11
using System.Threading.Tasks;
22
using FluentAssertions;
3+
using IO.Ably.Tests.Shared.Helpers;
4+
using Newtonsoft.Json.Linq;
35
using Xunit;
46
using Xunit.Abstractions;
57

@@ -37,10 +39,20 @@ public async Task WithCorrectCipherParams_DecryptsMessagesCorrectly(Protocol pro
3739
var channel = client.Channels.Get(TestEnvironmentSettings.PresenceChannelName, new ChannelOptions(settings.CipherParams));
3840

3941
var presence = await channel.Presence.GetAsync();
40-
foreach (var message in presence.Items)
42+
presence.Items.Should().HaveCount(6);
43+
44+
presence.Items[0].Data.Should().Be("true");
45+
46+
var exampleObject = new JObject
4147
{
42-
message.Encoding.Should().BeNullOrEmpty();
43-
}
48+
["example"] = new JObject { ["json"] = "Object" }
49+
};
50+
JAssert.DeepEquals(exampleObject, presence.Items[1].Data as JObject, Output).Should().BeTrue();
51+
JAssert.DeepEquals(exampleObject, presence.Items[2].Data as JObject, Output).Should().BeTrue();
52+
53+
presence.Items[3].Data.Should().Be("24");
54+
presence.Items[4].Data.Should().Be("{ \"test\": \"This is a JSONObject clientData payload\"}");
55+
presence.Items[5].Data.Should().Be("This is a string clientData payload");
4456
}
4557
}
4658
}

0 commit comments

Comments
 (0)