Change return type of _throwNoPayloadError to never

This informs the compiler that the function throws.

Author: lawrence-forooghian

src/plugins/liveobjects/livecounter.ts

@@ -137,8 +137,6 @@ export class LiveCounter extends LiveObject<LiveCounterData, LiveCounterUpdate>
       case ObjectOperationAction.COUNTER_INC:
         if (this._client.Utils.isNil(op.counterOp)) {
           this._throwNoPayloadError(op);
-          // leave an explicit return here, so that TS knows that update object is always set after the switch statement.
-          return;
         } else {
           update = this._applyCounterInc(op.counterOp, msg);
         }
@@ -263,7 +261,7 @@ export class LiveCounter extends LiveObject<LiveCounterData, LiveCounterUpdate>
     };
   }
 
-  private _throwNoPayloadError(op: ObjectOperation<ObjectData>): void {
+  private _throwNoPayloadError(op: ObjectOperation<ObjectData>): never {
     throw new this._client.ErrorInfo(
       `No payload found for ${op.action} op for LiveCounter objectId=${this.getObjectId()}`,
       92000,

src/plugins/liveobjects/livemap.ts

@@ -334,8 +334,6 @@ export class LiveMap<T extends Record<string, Value> = Record<string, Value>>
       case ObjectOperationAction.MAP_SET:
         if (this._client.Utils.isNil(op.mapOp)) {
           this._throwNoPayloadError(op);
-          // leave an explicit return here, so that TS knows that update object is always set after the switch statement.
-          return;
         } else {
           update = this._applyMapSet(op.mapOp, opSerial, msg);
         }
@@ -344,8 +342,6 @@ export class LiveMap<T extends Record<string, Value> = Record<string, Value>>
       case ObjectOperationAction.MAP_REMOVE:
         if (this._client.Utils.isNil(op.mapOp)) {
           this._throwNoPayloadError(op);
-          // leave an explicit return here, so that TS knows that update object is always set after the switch statement.
-          return;
         } else {
           update = this._applyMapRemove(op.mapOp, opSerial, msg.serialTimestamp, msg);
         }
@@ -683,7 +679,7 @@ export class LiveMap<T extends Record<string, Value> = Record<string, Value>>
     return aggregatedUpdate;
   }
 
-  private _throwNoPayloadError(op: ObjectOperation<ObjectData>): void {
+  private _throwNoPayloadError(op: ObjectOperation<ObjectData>): never {
     throw new this._client.ErrorInfo(
       `No payload found for ${op.action} op for LiveMap objectId=${this.getObjectId()}`,
       92000,