Skip to content

Commit dad669f

Browse files
committed
Fix request_version test is not async
Test actually didn't work properly before this fix. Helper.testOnJsonMsgpack expects an async function test, but the test was callback based on tried to use done() callback - which wasn't even provided.
1 parent cd9eca1 commit dad669f

File tree

1 file changed

+12
-4
lines changed

1 file changed

+12
-4
lines changed

test/rest/request.test.js

Lines changed: 12 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -28,17 +28,24 @@ define(['ably', 'shared_helper', 'async', 'chai'], function (Ably, Helper, async
2828
* @specpartial RSC7e - tests providing a version value in .request parameters
2929
* @specpartial CSV2c - tests version is provided in http requests
3030
*/
31-
Helper.testOnJsonMsgpack('request_version', function (options, _, helper) {
31+
Helper.testOnJsonMsgpack('request_version', async function (options, _, helper) {
3232
const rest = helper.AblyRest(options);
3333
const version = 150; // arbitrarily chosen
3434

35+
let savedResolve;
36+
let savedReject;
37+
let promise = new Promise((res, rej) => {
38+
savedResolve = res;
39+
savedReject = rej;
40+
});
41+
3542
async function testRequestHandler(_, __, headers) {
3643
try {
3744
expect('X-Ably-Version' in headers, 'Verify version header exists').to.be.ok;
3845
expect(headers['X-Ably-Version']).to.equal(version.toString(), 'Verify version number sent in request');
39-
done();
40-
} catch (err) {
41-
done(err);
46+
savedResolve();
47+
} catch (error) {
48+
savedReject(error);
4249
}
4350
return new Promise(() => {});
4451
}
@@ -47,6 +54,7 @@ define(['ably', 'shared_helper', 'async', 'chai'], function (Ably, Helper, async
4754
rest.http.do = testRequestHandler;
4855

4956
rest.request('get', '/time' /* arbitrarily chosen */, version, null, null, null);
57+
await promise;
5058
});
5159

5260
/**

0 commit comments

Comments
 (0)