The tool may be able to fail silently without the node process returning an indicative exit code

[QuintinWillison]

I just experienced this locally, while working on #42:

repository-audit % rm -Rf output
repository-audit % node .
Executing Query #1...
repository-audit % tree output
output [error opening dir]

0 directories, 0 files
repository-audit %

I've not noticed this in CI yet, but I find it troublesome that this could happen. We have other checks downstream that would fail the CI run if they don't find report output, however I would have expected to have seen an error thrown in the JS code. 🤔

Simply running again immediately after resulted in the expected outcome:

repository-audit % node .
Executing Query #1...
Executing Query #2...
Queried Repository Count: 181
repository-audit % tree output
output
├── commit-message.txt
├── internal
│   └── ably.md
└── public
    └── ably.md

2 directories, 3 files
repository-audit %

@owenpearson any suggestions of what might have been going on here? 😕

If it helps, and for clarity, my zsh prompt shows me exit code at the start of line - for example the ?1 here:

repository-audit % true
repository-audit % false
?1 repository-audit %

I keep my terminal configuration very simple - in this case showing exit codes via this in ~/.zshrc:

PROMPT='%(?..%F{red}?%? )%f%B%F{240}%1~%f%b %# '

[QuintinWillison]

Perhaps related, perhaps unrelated, GitHub may be experiencing instability this morning. Just seen this in latest rehearsal run:

Executing Query #1...
Executing Query #2...
RequestError [HttpError]: Unknown error: {"data":null,"errors":[{"message":"Something went wrong while executing your query. This may be the result of a timeout, or it could be a GitHub bug. Please include `0402:07BB:1F6FF35:436A1C0:61668452` when reporting this issue."}]}
    at /home/runner/work/repository-audit/repository-audit/node_modules/@octokit/request/dist-node/index.js:86:21
    at processTicksAndRejections (internal/process/task_queues.js:95:5)
    at async sendRequestWithRetries (/home/runner/work/repository-audit/repository-audit/node_modules/@octokit/auth-app/dist-node/index.js:466:12)
    at async audit (/home/runner/work/repository-audit/repository-audit/src/index.js:120:30)
    at async /home/runner/work/repository-audit/repository-audit/src/index.js:21:5 {
  status: 502,
  response: {
    url: 'https://api.github.com/graphql',
    status: 502,
    headers: {
      'access-control-allow-origin': '*',
      'access-control-expose-headers': 'ETag, Link, Location, Retry-After, X-GitHub-OTP, X-RateLimit-Limit, X-RateLimit-Remaining, X-RateLimit-Reset, X-OAuth-Scopes, X-Accepted-OAuth-Scopes, X-Poll-Interval, X-GitHub-Media-Type, Deprecation, Sunset',
      connection: 'close',
      'content-type': 'application/json',
      date: 'Wed, 13 Oct 2021 07:01:52 GMT',
      server: 'GitHub.com',
      'transfer-encoding': 'chunked',
      vary: 'Accept-Encoding, Accept, X-Requested-With',
      'x-github-request-id': '0402:07BB:1F6FF35:436A1C0:61668452'
    },
    data: { data: null, errors: [Array] }
  },
  request: {
    method: 'POST',
    url: 'https://api.github.com/graphql',
    headers: {
      accept: 'application/vnd.github.v3+json',
      'user-agent': 'octokit-graphql.js/4.8.0 Node.js/14.18.0 (linux; x64)',
      authorization: 'token [REDACTED]',
      'content-type': 'application/json; charset=utf-8'
    },
    body: '{"query":"query repositories($orgName: String!, $previousEndCursor: String) {\\n    organization(login: $orgName) {\\n      repositories(first: 100, after: $previousEndCursor) {\\n        nodes {\\n          name\\n          hasIssuesEnabled\\n          hasProjectsEnabled\\n          hasWikiEnabled\\n          forkingAllowed\\n          deleteBranchOnMerge\\n          rebaseMergeAllowed\\n          squashMergeAllowed\\n          mergeCommitAllowed\\n          autoMergeAllowed\\n          defaultBranchRef {\\n            name\\n          }\\n          visibility\\n          branchProtectionRules(first: 100) {\\n            nodes {\\n              requiredApprovingReviewCount\\n              requiresApprovingReviews\\n              requiresConversationResolution\\n              requiresStatusChecks\\n              requiresStrictStatusChecks\\n              restrictsPushes\\n              pattern\\n              allowsDeletions\\n              allowsForcePushes\\n            }\\n            pageInfo {\\n              hasNextPage\\n            }\\n          }\\n        }\\n        pageInfo {\\n          endCursor\\n          hasNextPage\\n        }\\n      }\\n    }\\n  }","variables":{"orgName":"ably","previousEndCursor":"Y3Vyc29yOnYyOpHODAIlNw=="}}',
    request: { hook: [Function: bound hook] AsyncFunction }
  }
}
Error: Process completed with exit code 2.

[owenpearson]

@QuintinWillison Will have a look in to the original issue when I have time, but I think the second comment is related to https://www.githubstatus.com/incidents/81lpnf07bm1q