Skip to content

Commit 9eaf6b2

Browse files
committed
Remove ghost packages from non vuln versions
Signed-off-by: Tushar Goel <tushar.goel.dav@gmail.com>
1 parent 80fdcf1 commit 9eaf6b2

1 file changed

Lines changed: 1 addition & 18 deletions

File tree

vulnerabilities/models.py

Lines changed: 1 addition & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -3583,9 +3583,6 @@ def bulk_get_or_create_from_purls(self, purls: List[Union[PackageURL, str]]):
35833583
def only_vulnerable(self):
35843584
return self._vulnerable()
35853585

3586-
def only_non_vulnerable(self):
3587-
return self._not_vulnerable().filter(is_ghost=False)
3588-
35893586
def for_purl(self, purl):
35903587
"""
35913588
Return a queryset matching the ``purl`` Package URL.
@@ -3624,20 +3621,6 @@ def with_is_vulnerable(self):
36243621
)
36253622
)
36263623

3627-
def with_is_not_vulnerable(self):
3628-
"""
3629-
Annotate Package with ``is_not_vulnerable`` boolean attribute.
3630-
"""
3631-
return self.annotate(
3632-
is_not_vulnerable=Exists(
3633-
ImpactedPackageFixedBy.objects.filter(
3634-
package__pk=OuterRef("pk"),
3635-
impacted_package__advisory__is_latest=True,
3636-
impacted_package__advisory___all_impacts_unfurled_at__isnull=False,
3637-
)
3638-
)
3639-
)
3640-
36413624
def all_vulnerable(self):
36423625
latest_unfurled_impacts = ImpactedPackageAffecting.objects.filter(
36433626
package_id=OuterRef("pk"),
@@ -3808,7 +3791,7 @@ def get_non_vulnerable_versions(self):
38083791
qs = (
38093792
PackageV2.objects.get_fixed_by_package_versions(self, fix=False)
38103793
.annotate(evaluated=evaluated, vulnerable=vulnerable)
3811-
.filter(evaluated=True, vulnerable=False)
3794+
.filter(evaluated=True, vulnerable=False, is_ghost=False)
38123795
.filter(version_rank__gt=self.version_rank)
38133796
.order_by("version_rank")
38143797
)

0 commit comments

Comments
 (0)