Rework Test Case 0002

Rework Test Case 0002

Author: abraunegg

ci/e2e/framework/context.py

@@ -62,16 +62,14 @@ def master_log_file(self) -> Path:
 
     @property
     def default_onedrive_config_dir(self) -> Path:
-        """
-        Return the default OneDrive config directory created by the workflow.
-        """
         xdg_config_home = os.environ.get("XDG_CONFIG_HOME", "").strip()
         if xdg_config_home:
             return Path(xdg_config_home) / "onedrive"
 
         home = os.environ.get("HOME", "").strip()
         if not home:
             raise RuntimeError("Neither XDG_CONFIG_HOME nor HOME is set")
+
         return Path(home) / ".config" / "onedrive"
 
     @property
@@ -86,10 +84,7 @@ def ensure_refresh_token_available(self) -> None:
 
     def bootstrap_config_dir(self, config_dir: Path) -> Path:
         """
-        Create a usable OneDrive config directory for a test case by copying the
-        existing refresh_token into the supplied config directory.
-
-        Returns the path to the copied refresh_token.
+        Copy the existing refresh_token into a per-test/per-scenario config dir.
         """
         self.ensure_refresh_token_available()
         ensure_directory(config_dir)

ci/e2e/framework/manifest.py

@@ -23,28 +23,4 @@ def build_manifest(root: Path) -> list[str]:
 
 def write_manifest(path: Path, entries: list[str]) -> None:
     path.parent.mkdir(parents=True, exist_ok=True)
-    path.write_text("\n".join(entries) + ("\n" if entries else ""), encoding="utf-8")
-
-
-def compare_manifest(
-    actual_entries: list[str],
-    expected_present: list[str],
-    expected_absent: list[str],
-) -> list[str]:
-    """
-    Compare actual manifest entries against expected present/absent paths.
-
-    Returns a list of diff lines. Empty list means success.
-    """
-    diffs: list[str] = []
-    actual_set = set(actual_entries)
-
-    for expected in expected_present:
-        if expected not in actual_set:
-            diffs.append(f"MISSING expected path: {expected}")
-
-    for unexpected in expected_absent:
-        if unexpected in actual_set:
-            diffs.append(f"FOUND unexpected path: {unexpected}")
-
-    return diffs
+    path.write_text("\n".join(entries) + ("\n" if entries else ""), encoding="utf-8")

ci/e2e/testcases/tc0001_basic_resync.py

@@ -24,15 +24,15 @@ class TestCase0001BasicResync(E2ETestCase):
 
     def run(self, context: E2EContext) -> TestResult:
 
-        context.ensure_refresh_token_available()
-        
         case_work_dir = context.work_root / f"tc{self.case_id}"
         case_log_dir = context.logs_dir / f"tc{self.case_id}"
         state_dir = context.state_dir / f"tc{self.case_id}"
 
         reset_directory(case_work_dir)
         reset_directory(case_log_dir)
         reset_directory(state_dir)
+        
+        context.ensure_refresh_token_available()
 
         stdout_file = case_log_dir / "stdout.log"
         stderr_file = case_log_dir / "stderr.log"