From 32d5b2834c004bd1d1458ac4d7d7ee473e77e20f Mon Sep 17 00:00:00 2001 From: Javid Khan Date: Tue, 14 Jul 2026 15:42:38 +0530 Subject: [PATCH] fix reversed operand in ShouldPickFirstSymbol tie-break --- absl/debugging/symbolize_elf.inc | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/absl/debugging/symbolize_elf.inc b/absl/debugging/symbolize_elf.inc index 56f31afbafc..269312d491f 100644 --- a/absl/debugging/symbolize_elf.inc +++ b/absl/debugging/symbolize_elf.inc @@ -712,7 +712,7 @@ static bool ShouldPickFirstSymbol(const ElfW(Sym) & symbol1, // If one of the symbols is weak and the other is not, pick the one // this is not a weak symbol. char bind1 = ELF_ST_BIND(symbol1.st_info); - char bind2 = ELF_ST_BIND(symbol1.st_info); + char bind2 = ELF_ST_BIND(symbol2.st_info); if (bind1 == STB_WEAK && bind2 != STB_WEAK) return false; if (bind2 == STB_WEAK && bind1 != STB_WEAK) return true; @@ -728,7 +728,7 @@ static bool ShouldPickFirstSymbol(const ElfW(Sym) & symbol1, // If one of the symbols has no type and the other is not, pick the // one that has a type. char type1 = ELF_ST_TYPE(symbol1.st_info); - char type2 = ELF_ST_TYPE(symbol1.st_info); + char type2 = ELF_ST_TYPE(symbol2.st_info); if (type1 != STT_NOTYPE && type2 == STT_NOTYPE) { return true; }