Merge pull request #1188 from maartenvanvliet/default-enum-value-present

Fix default enum value present for SDL schemas

Author: benwilson512

CHANGELOG.md

@@ -9,6 +9,7 @@
 - Bug Fix: [Add type system directives to introspection results](https://github.com/absinthe-graphql/absinthe/pull/1189)
 - Bug Fix: [Add `__private__` field to EnumValueDefinition](https://github.com/absinthe-graphql/absinthe/pull/1148)
 - Bug Fix: [Fix bug in Schema.**absinthe_types**(:all) for Persistent Term](https://github.com/absinthe-graphql/absinthe/pull/1161)
+- Bug Fix: [Fix default enum value check for SDL schema's](https://github.com/absinthe-graphql/absinthe/pull/1188)
 - Feature: [Add `import_directives` macro](https://github.com/absinthe-graphql/absinthe/pull/1158)
 - Feature: [Support type extensions on schema declarations](https://github.com/absinthe-graphql/absinthe/pull/1176)
 - Bug Fix: [Root objects are marked as referenced correctly](https://github.com/absinthe-graphql/absinthe/pull/1186)

lib/absinthe/phase/schema/validation/default_enum_value_present.ex

@@ -15,20 +15,21 @@ defmodule Absinthe.Phase.Schema.Validation.DefaultEnumValuePresent do
       |> Enum.filter(&match?(%Schema.EnumTypeDefinition{}, &1))
       |> Map.new(&{&1.identifier, &1})
 
-    schema = Blueprint.prewalk(schema, &validate_defaults(&1, enums))
+    schema = Blueprint.prewalk(schema, &validate_defaults(&1, enums, schema))
     {:halt, schema}
   end
 
   def validate_schema(node), do: node
 
-  def validate_defaults(%{default_value: nil} = node, _) do
+  def validate_defaults(%{default_value: nil} = node, _, _) do
     node
   end
 
-  def validate_defaults(%{default_value: default_value, type: type} = node, enums) do
-    type = Blueprint.TypeReference.unwrap(type)
+  def validate_defaults(%{default_value: default_value, type: type} = node, enums, schema) do
+    type_identifier =
+      Blueprint.TypeReference.unwrap(type) |> Blueprint.TypeReference.to_type(schema)
 
-    case Map.fetch(enums, type) do
+    case Map.fetch(enums, type_identifier) do
       {:ok, enum} ->
         values = Enum.map(enum.values, & &1.value)
         value_list = Enum.map(values, &"\n * #{inspect(&1)}")
@@ -52,7 +53,7 @@ defmodule Absinthe.Phase.Schema.Validation.DefaultEnumValuePresent do
     end
   end
 
-  def validate_defaults(node, _) do
+  def validate_defaults(node, _, _) do
     node
   end
 

test/absinthe/schema/rule/default_enum_value_present_test.exs

@@ -1,7 +1,86 @@
 defmodule Absinthe.Schema.Rule.DefaultEnumValuePresentTest do
   use Absinthe.Case, async: true
 
-  describe "rule" do
+  describe "SDL schema" do
+    test "is enforced when the default_value is not in the enum" do
+      schema = """
+      defmodule BadColorSchemaSdl do
+        use Absinthe.Schema
+
+        import_sdl "
+        enum Channel {
+          RED
+          GREEN
+        }
+
+        type Query {
+          info(channel: Channel! = OTHER): Channel
+        }
+        "
+      end
+      """
+
+      error = ~r/The default_value for an enum must be present in the enum values/
+
+      assert_raise(Absinthe.Schema.Error, error, fn ->
+        Code.eval_string(schema)
+      end)
+    end
+
+    test "is enforced when the default_value is a list of enums and some items are not in the enum" do
+      schema = """
+      defmodule MovieSchemaSdl do
+        use Absinthe.Schema
+
+
+        import_sdl "
+        enum MovieGenre {
+          ACTION
+          COMEDY
+          SF
+        }
+
+        type Query {
+          movies(genres: [MovieGenre!]! = [ACTION, OTHER]): [MovieGenre!]!
+        }
+        "
+      end
+      """
+
+      error = ~r/The default_value for an enum must be present in the enum values/
+
+      assert_raise(Absinthe.Schema.Error, error, fn ->
+        Code.eval_string(schema)
+      end)
+    end
+
+    test "passes when the default_value is a list and that list is a valid enum value" do
+      schema = """
+      defmodule CorrectCatSchemSdl do
+        use Absinthe.Schema
+
+        import_sdl "
+        enum CatOrderBy {
+          NAME_ASC
+          NAME_DESC_INSERTED_AT_ASC
+        }
+
+        type Query {
+          cat(orderBy: [CatOrderBy!] = [NAME_ASC]): [Cat!]!
+        }
+
+        type Cat {
+          name: String
+        }
+        "
+      end
+      """
+
+      assert Code.eval_string(schema)
+    end
+  end
+
+  describe "macro schema" do
     test "is enforced when the default_value is not in the enum" do
       schema = """
       defmodule BadColorSchema do