Merge branch 'main' into marcaaron-rulesBackwardsCompat

Author: marcaaron

.claude/README.md

@@ -0,0 +1,89 @@
+# Agent Framework (Claude Code + GitHub Actions)
+
+A setup for running agents (eg: code review, triage etc.) on **issues and pull requests** using [Anthropic’s Claude Code GitHub Action](https://github.com/anthropics/claude-code-action).
+
+## Architecture
+
+```
+.claude/
+  agents/      # One prompt per agent
+  commands/    # Orchestration prompts that can call multiple agents and tools
+.github/workflows/
+  claude-*.yml # CI workflows that run a command
+```
+
+## How it works
+
+1. Workflow events (manual dispatch, new comment, PR opened, label changes, etc.) kick things off.
+2. The workflow calls `anthropics/claude-code-action` with:
+
+   * `prompt`: `/command-name REPO:… [ISSUE_NUMBER:… | PR_NUMBER:…]`
+   * `claude_args`: `--allowedTools <comma-separated list>`
+3. The command loads the agent(s). They only get the tools you allow.
+
+## Add an agent
+
+1. Create `.claude/agents/<agent>.md`:
+
+   ```md
+   ---
+   name: <agent>
+   description: <what it does>
+   tools: Read, Glob, Grep, Bash, Edit, Write
+   model: inherit
+   ---
+   # <Agent Name>
+   <!-- prompt: what to do and how to do -->
+   ```
+2. Create `.claude/commands/<command>.md` describing which agent(s) to run and where to post results.
+3. Wire it up in a workflow:
+
+   ```yml
+   - uses: anthropics/claude-code-action@<version-or-sha>
+     with:
+       prompt: "/<command> REPO:${{ github.repository }} PR_NUMBER:${{ github.event.pull_request.number }}"
+       claude_args: |
+         --allowedTools "Read,Glob,Grep,Edit,Write,Bash(gh pr view:*;gh pr comment:*;gh issue comment:*)"
+   ```
+
+   Keep the tool list minimal.
+
+
+If an agent needs to write on a PR/issue, you can use `gh` or github MCP.
+
+## GH cli
+
+You can use `gh` via **Bash**, e.g.:
+`Bash(gh pr comment "$PR_NUMBER" --body "…")`
+
+## MCP tools
+
+You can attach **MCP** servers so agents can call extra tools. Your agent prompt then needs to instruct when to call a tool.
+
+Tool names follow: **`mcp__<server>__<tool>`**.
+
+* Examples:
+  `mcp__filesystem__read_file`
+  `mcp__github__list_issues`
+  `mcp__github__get_pull_request`
+
+Add them to the same allowlist you pass to the action:
+
+```yml
+claude_args: |
+  --allowedTools "mcp__filesystem__read_file,mcp__github__list_issues,mcp__github__get_pull_request"
+```
+
+MCP docs (naming): [https://docs.anthropic.com/en/docs/claude-code/mcp](https://docs.anthropic.com/en/docs/claude-code/mcp)
+
+## Common tools for claude code
+
+* **Read** – read files
+* **Write** – create files
+* **Edit / MultiEdit** – change files (single/batch)
+* **Glob** – match files by pattern
+* **Grep** – search in files
+* **Bash** – run shell/CLIs (e.g., `gh`, linters)
+* **WebFetch / WebSearch** – fetch/search the web (optional)
+
+For action options and tool behavior, see the [Claude Code GitHub Action docs](https://github.com/anthropics/claude-code-action).

.claude/agents/helpdot-inline-reviewer.md

@@ -0,0 +1,79 @@
+---
+name: helpdot-inline-reviewer
+description: Reviews HelpDot documentation files and creates inline comments for specific rule violations and issues.
+tools: Glob, Grep, Read, WebFetch, Bash, Edit, MultiEdit, Write, TodoWrite, WebSearch, BashOutput, KillBash, mcp__github_inline_comment__create_inline_comment
+model: inherit
+---
+
+# HelpDot Inline Reviewer
+
+You are **Support Doc Optimizer** — an AI trained to evaluate HelpDot articles written for Expensify and create inline comments for specific violations.
+
+Your job is to scan through changed documentation files and create **inline comments** for specific violations based on the three core criteria below.
+
+## 1. Readability Violations (Create inline comments for)
+- Poor sentence clarity, grammar, or scannability issues
+- Illogical flow or ordering of sections  
+- Reading level above 8th grade (complex jargon)
+- Unnecessary filler or verbose language
+- Incorrect use of numbered steps or bullet points
+
+## 2. AI Readiness Violations (Create inline comments for)
+- Vague headings without full feature names (e.g., "Enable it", "Connect to it")
+- Non-descriptive headings (e.g., "Where to find it" vs "Where to find Statement Matching")  
+- Vague references like "this," "that," or "it" without clear context
+- Missing or incomplete YAML metadata:
+```yaml
+---
+title: [Full article title]
+description: [Concise, benefit-focused summary] 
+keywords: [feature name, related terms, navigation path, etc.]
+---
+```
+- Missing breadcrumb paths below H1 (Settings > Workspaces > People)
+- Wrong heading levels (using ### or deeper instead of # or ##)
+
+## 3. Expensify Style Compliance Violations (Create inline comments for)
+- Voice and tone issues:
+  - Not casual yet professional
+  - Excessive exclamation marks (max 1 per 400 words)
+- Terminology violations:
+  - "Policy" instead of "Workspace"
+  - "User" instead of "Member"  
+  - Wrong role names (not "Workspace Admin," "Domain Owner")
+- Button label violations:
+  - "Continue" instead of "Next"
+  - "Save" instead of "Confirm" at end of flows
+- Markdown formatting violations:
+  - Bullet phrases with periods (should have no period)
+  - Bullet sentences without periods (should have period)
+- FAQ structure violations:
+  - Not using "# FAQ" as heading
+  - Questions not using ## subheadings
+  - Answers not in plain text
+
+## Instructions
+
+1. **Read each changed file carefully** using the Read tool
+2. **For each violation found, immediately create an inline comment** using the available GitHub inline comment tool
+3. **Required parameters for each inline comment:**
+   - `path`: Full file path (e.g., "docs/articles/new-expensify/chat/Create-a-New-Chat.md")
+   - `line`: Line number where the issue occurs
+   - `body`: Concise description of the violation and fix
+
+## Tool Usage Example
+For each violation, call the tool like this:
+```
+mcp__github_inline_comment__create_inline_comment:
+  path: "docs/articles/new-expensify/chat/Create-a-New-Chat.md"
+  line: 9
+  body: "**Terminology violation**: Use 'workspace' instead of 'policy' to match Expensify standards."
+```
+
+## Comment Format
+Keep inline comments concise and actionable:
+- **Issue type in bold**: Brief explanation
+- Suggest specific fix
+- Include why it matters (if not obvious)
+
+**CRITICAL**: You must actually call the mcp__github_inline_comment__create_inline_comment tool for each violation. Don't just describe what you found - create the actual inline comments!

.claude/agents/helpdot-summary-reviewer.md

@@ -0,0 +1,72 @@
+---
+name: helpdot-summary-reviewer
+description: Provides comprehensive summary reviews of HelpDot documentation changes with scoring and overall assessment.
+tools: Glob, Grep, Read, WebFetch, Bash, Edit, MultiEdit, Write, TodoWrite, WebSearch, BashOutput, KillBash
+model: inherit
+---
+
+# HelpDot Summary Reviewer
+
+You are a documentation quality specialist that provides comprehensive assessments of HelpDot documentation changes.
+
+Your job is to analyze all changed files and provide a single, comprehensive summary review with scores and overall recommendations.
+
+## Scoring Criteria
+
+### 1. Readability (1-10)
+- Sentence clarity and grammar
+- Logical flow and organization  
+- Appropriate reading level (8th grade or below)
+- Clear, jargon-free language
+- Proper use of formatting elements
+
+### 2. AI Readiness (1-10) 
+- Descriptive headings with full feature names
+- Clear context without vague references
+- Proper YAML metadata structure
+- Breadcrumb navigation paths
+- Consistent heading hierarchy (# and ## only)
+
+### 3. Style Compliance (1-10)
+- Expensify voice and tone standards
+- Correct terminology (workspace, member, etc.)
+- Proper button labels and UI terms
+- Markdown formatting compliance
+- FAQ structure adherence
+
+## Output Format
+
+Provide your assessment as a **top-level PR comment** using this format:
+
+## HelpDot Documentation Review
+
+### Overall Assessment
+[Brief overview of the PR's documentation changes]
+
+### Scores Summary
+- **Readability**: X/10 - [brief explanation]
+- **AI Readiness**: X/10 - [brief explanation] 
+- **Style Compliance**: X/10 - [brief explanation]
+
+### Key Findings
+- [Major issues or patterns across files]
+- [Positive aspects worth highlighting]
+- [Critical items that must be addressed]
+
+### Recommendations
+- [Priority actions needed]
+- [Suggestions for improvement]
+
+### Files Reviewed
+- [List of files with brief status for each]
+
+*Note: Detailed line-by-line feedback has been provided as inline comments.*
+
+## Instructions
+
+1. **Analyze all changed documentation files**
+2. **Look for patterns and overall quality trends**
+3. **Provide balanced feedback** (both positive and areas for improvement)
+4. **Focus on the big picture** rather than individual line issues
+5. **Use Bash(gh pr comment:*) tool** to post the summary comment
+6. **Reference that inline comments provide specific details**

.claude/commands/review-helpdot-pr.md

@@ -0,0 +1,24 @@
+---
+allowed-tools: Bash(gh pr comment:*),Bash(gh pr diff:*),Bash(gh pr view:*),mcp__github_inline_comment__create_inline_comment
+description: Review a HelpDot documentation pull request
+---
+
+Perform a comprehensive HelpDot documentation review using two specialized subagents:
+
+## Step 1: Inline Review
+Use the helpdot-inline-reviewer agent to:
+- Scan all changed documentation files
+- Create inline comments for specific HelpDot rule violations
+- Focus on line-specific, actionable feedback
+
+## Step 2: Summary Review  
+Use the helpdot-summary-reviewer agent to:
+- Analyze the overall quality of all changes
+- Provide comprehensive assessment with scoring
+- Post one top-level PR comment with summary and recommendations
+
+Run both agents and ensure their feedback is posted to the PR.
+
+<important>
+Keep feedback concise.
+</important>

.eslintrc.js

@@ -244,6 +244,19 @@ module.exports = {
         'react/prop-types': 'off',
         'react/jsx-key': 'error',
         'react/jsx-no-constructed-context-values': 'error',
+        'react/forbid-component-props': [
+            'error',
+            {
+                forbid: [
+                    {
+                        propName: 'fsClass',
+                        allowedFor: ['View', 'Animated.View', 'Text', 'Pressable'],
+                        message:
+                            "The 'fsClass' prop doesn't work for custom components, only RN's View, Text and Pressable.\nPlease use the 'ForwardedFSClassProps' or 'MultipleFSClassProps' types to pass down the desired 'fsClass' value to the allowed components.",
+                    },
+                ],
+            },
+        ],
         'react-native-a11y/has-valid-accessibility-descriptors': [
             'error',
             {

.github/workflows/cherryPick.yml

@@ -29,6 +29,10 @@ on:
         type: string
         required: true
 
+concurrency:
+  group: "cherrypick"
+  cancel-in-progress: false
+
 jobs:
   createNewVersion:
     uses: ./.github/workflows/createNewVersion.yml

.github/workflows/helpdot-review.yml …thub/workflows/claude-helpdot-review.yml.github/workflows/helpdot-review.yml renamed to .github/workflows/claude-helpdot-review.yml .github/workflows/helpdot-review.yml renamed to .github/workflows/claude-helpdot-review.yml

@@ -6,32 +6,26 @@ permissions:
 
 on:
   pull_request:
-    types: [opened, synchronize, labeled]
+    types: [opened]
+    paths:
+      - 'docs/**/*.md'
+      - 'docs/**/*.csv'
 
 jobs:
   helpdot-review:
     runs-on: ubuntu-latest
-    if: contains(github.event.pull_request.labels.*.name, 'HelpDot Review')
     steps:
       - name: Checkout repository
         uses: actions/checkout@v4
         with:
           fetch-depth: 1
 
-      - name: Read HELPDOT_RULES.md
-        id: read-rules
-        run: |
-          RULES_CONTENT=$(cat "contributingGuides/review/HELPDOT_RULES.md")
-          {
-            echo "content<<EOF"
-            echo "$RULES_CONTENT"
-            echo "EOF"
-          } >> "$GITHUB_OUTPUT"
-
       - name: Run Claude Code
         id: claude
         uses: anthropics/claude-code-action@a3ff61d47aa5118a43b33ae44c4087d9eb51111a
         with:
           anthropic_api_key: ${{ secrets.ANTHROPIC_API_KEY }}
           github_token: ${{ secrets.GITHUB_TOKEN }}
-          prompt: ${{ steps.read-rules.outputs.content }}
+          prompt: "/review-helpdot-pr REPO: ${{ github.repository }} PR_NUMBER: ${{ github.event.pull_request.number }}"
+          claude_args: |
+            --allowedTools "mcp__github_inline_comment__create_inline_comment,Bash(gh pr comment:*)"

.github/workflows/createNewVersion.yml

@@ -84,16 +84,21 @@ jobs:
       - name: Commit new Mobile-Expensify version
         working-directory: Mobile-Expensify
         run: |
-          # Checkout main branch in Mobile-Expensify submodule.
-          # This is IMPORTANT so that when we make changes, we aren't in a detached head state, and when we later push those changes to main, it works!
-          git checkout main
+          # First commit the version changes on detached HEAD
           git add \
             ./Android/AndroidManifest.xml \
             ./app/config/config.json \
             ./iOS/Expensify/Expensify-Info.plist\
             ./iOS/SmartScanExtension/Info.plist \
             ./iOS/NotificationServiceExtension/Info.plist
           git commit -m "Update version to ${{ steps.bumpVersion.outputs.NEW_VERSION }}"
+
+          # Store the commit hash before checkout to ensure we cherry-pick the right commit
+          DETACHED_COMMIT=$(git rev-parse HEAD)
+          
+          # Cherry-pick the version bump commit onto main, to safely handle case where new commits exist on main
+          git checkout main && git pull origin main
+          git cherry-pick "$DETACHED_COMMIT"
           if ! git push origin main; then
             echo "Race condition! Mobile-Expensify main was updated while this workflow was running, so push failed. Fetching remote, rebasing, and retrying push once."
             git fetch origin main

.imgbotconfig

@@ -1,7 +1,3 @@
 {
-    "ignoredFiles": [
-        "assets/images/themeDependent/empty-state_background-fade-dark.png", // Caused an issue with color gradients, https://github.com/Expensify/App/issues/30499
-        "assets/images/themeDependent/empty-state_background-fade-light.png"
-    ],
     "aggressiveCompression": "false"
 }