Skip to content

Commit 649ff16

Browse files
committed
address comments.
Signed-off-by: krishna2323 <belivethatkg@gmail.com>
1 parent 8b78618 commit 649ff16

1 file changed

Lines changed: 19 additions & 6 deletions

File tree

src/components/PopoverMenu.tsx

Lines changed: 19 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -516,11 +516,24 @@ function BasePopoverMenu({
516516
...restContainerStyles
517517
} = StyleSheet.flatten(containerStyles) ?? {};
518518

519-
const scrollViewPaddingStyles = {
520-
paddingTop: paddingTop ?? containerPaddingTop ?? menuContainerPaddingTop,
521-
paddingBottom: paddingBottom ?? containerPaddingBottom ?? menuContainerPaddingBottom,
522-
paddingVertical: paddingVertical ?? containerPaddingVertical ?? menuContainerPaddingVertical ?? 0,
523-
};
519+
const scrollViewPaddingStyles = useMemo(
520+
() => ({
521+
paddingTop: paddingTop ?? containerPaddingTop ?? menuContainerPaddingTop,
522+
paddingBottom: paddingBottom ?? containerPaddingBottom ?? menuContainerPaddingBottom,
523+
paddingVertical: paddingVertical ?? containerPaddingVertical ?? menuContainerPaddingVertical ?? 0,
524+
}),
525+
[
526+
paddingTop,
527+
containerPaddingTop,
528+
menuContainerPaddingTop,
529+
paddingBottom,
530+
containerPaddingBottom,
531+
menuContainerPaddingBottom,
532+
paddingVertical,
533+
containerPaddingVertical,
534+
menuContainerPaddingVertical,
535+
],
536+
);
524537

525538
return (
526539
<PopoverWithMeasuredContent
@@ -556,7 +569,7 @@ function BasePopoverMenu({
556569
>
557570
<View
558571
onLayout={onLayout}
559-
style={[restMenuContainerStyle, restContainerStyles, {...(isWebOrDesktop ? styles.flex1 : styles.flexGrow1)}]}
572+
style={[restMenuContainerStyle, restContainerStyles, isWebOrDesktop ? styles.flex1 : styles.flexGrow1]}
560573
>
561574
{renderWithConditionalWrapper(
562575
shouldUseScrollView,

0 commit comments

Comments
 (0)