Merge pull request Expensify#74560 from DylanDylann/fix-app-perf

[No QA]: Fix App performance

Author: lakchote

src/libs/PersonalDetailsUtils.ts

@@ -36,15 +36,31 @@ Onyx.connect({
     },
 });
 
+let hiddenTranslation = '';
+let youTranslation = '';
+
+Onyx.connect({
+    key: ONYXKEYS.ARE_TRANSLATIONS_LOADING,
+    initWithStoredValues: false,
+    callback: (value) => {
+        if (value ?? true) {
+            return;
+        }
+        // eslint-disable-next-line @typescript-eslint/no-deprecated
+        hiddenTranslation = translateLocal('common.hidden');
+        // eslint-disable-next-line @typescript-eslint/no-deprecated
+        youTranslation = translateLocal('common.you').toLowerCase();
+    },
+});
+
 const regexMergedAccount = new RegExp(CONST.REGEX.MERGED_ACCOUNT_PREFIX);
 
 function getDisplayNameOrDefault(
     passedPersonalDetails?: Partial<PersonalDetails> | null,
     defaultValue = '',
     shouldFallbackToHidden = true,
     shouldAddCurrentUserPostfix = false,
-    // eslint-disable-next-line @typescript-eslint/no-deprecated
-    youAfterTranslation = translateLocal('common.you').toLowerCase(),
+    youAfterTranslation = youTranslation,
 ): string {
     let displayName = passedPersonalDetails?.displayName ?? '';
 
@@ -84,8 +100,7 @@ function getDisplayNameOrDefault(
     if (login) {
         return login;
     }
-    // eslint-disable-next-line @typescript-eslint/no-deprecated
-    return shouldFallbackToHidden ? translateLocal('common.hidden') : '';
+    return shouldFallbackToHidden ? hiddenTranslation : '';
 }
 
 /**

src/libs/ReportUtils.ts

@@ -1177,6 +1177,23 @@ Onyx.connect({
     },
 });
 
+let hiddenTranslation = '';
+let unavailableTranslation = '';
+
+Onyx.connect({
+    key: ONYXKEYS.ARE_TRANSLATIONS_LOADING,
+    initWithStoredValues: false,
+    callback: (value) => {
+        if (value ?? true) {
+            return;
+        }
+        // eslint-disable-next-line @typescript-eslint/no-deprecated
+        hiddenTranslation = translateLocal('common.hidden');
+        // eslint-disable-next-line @typescript-eslint/no-deprecated
+        unavailableTranslation = translateLocal('workspace.common.unavailable');
+    },
+});
+
 function getCurrentUserAvatar(): AvatarSource | undefined {
     return currentUserPersonalDetails?.avatar;
 }
@@ -1320,8 +1337,7 @@ function getPolicyType(report: OnyxInputOrEntry<Report>, policies: OnyxCollectio
  * Get the policy name from a given report
  */
 function getPolicyName({report, returnEmptyIfNotFound = false, policy, policies, reports}: GetPolicyNameParams): string {
-    // eslint-disable-next-line @typescript-eslint/no-deprecated
-    const noPolicyFound: string = returnEmptyIfNotFound ? '' : translateLocal('workspace.common.unavailable');
+    const noPolicyFound = returnEmptyIfNotFound ? '' : unavailableTranslation;
     const parentReport = report ? getRootParentReport({report, reports}) : undefined;
 
     if (isEmptyObject(report) || (isEmptyObject(policies) && isEmptyObject(allPolicies) && !report?.policyName && !parentReport?.policyName)) {
@@ -3107,8 +3123,7 @@ function getDisplayNameForParticipant({
     }
 
     // If the user's personal details (first name) should be hidden, make sure we return "hidden" instead of the short name
-    // eslint-disable-next-line @typescript-eslint/no-deprecated
-    if (shouldFallbackToHidden && longName === translateLocal('common.hidden')) {
+    if (shouldFallbackToHidden && longName === hiddenTranslation) {
         return longName;
     }