Skip to content

Commit c06db73

Browse files
committed
fix comments
1 parent eb35e7b commit c06db73

5 files changed

Lines changed: 46 additions & 49 deletions

File tree

src/components/RecordTroubleshootDataToolMenu/handleStopRecording.native.ts renamed to src/components/RecordTroubleshootDataToolMenu/finalizeStopRecording.ts

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,14 +1,19 @@
11
import type StopRecordingParams from './handleStopRecording.types';
22

3-
export default async function handleStopRecording({
3+
type FinalizeStopRecordingParams = Pick<
4+
StopRecordingParams,
5+
'infoFileName' | 'appInfo' | 'logsWithParsedMessages' | 'onDisableLogging' | 'cleanupAfterDisable' | 'zipRef' | 'onDownloadZip'
6+
>;
7+
8+
export default async function finalizeStopRecording({
49
infoFileName,
510
appInfo,
611
logsWithParsedMessages,
712
onDisableLogging,
813
cleanupAfterDisable,
914
zipRef,
1015
onDownloadZip,
11-
}: StopRecordingParams): Promise<void> {
16+
}: FinalizeStopRecordingParams): Promise<void> {
1217
zipRef.current?.file(infoFileName, appInfo);
1318

1419
await onDisableLogging(logsWithParsedMessages);

src/components/RecordTroubleshootDataToolMenu/handleStopRecording.android.ts

Lines changed: 10 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
import RNFetchBlob from 'react-native-blob-util';
2+
import finalizeStopRecording from './finalizeStopRecording';
23
import type StopRecordingParams from './handleStopRecording.types';
34

45
export default async function handleStopRecording({
@@ -24,9 +25,13 @@ export default async function handleStopRecording({
2425
}
2526
}
2627

27-
zipRef.current?.file(infoFileName, appInfo);
28-
29-
await onDisableLogging(logsWithParsedMessages);
30-
cleanupAfterDisable();
31-
onDownloadZip?.();
28+
await finalizeStopRecording({
29+
infoFileName,
30+
appInfo,
31+
logsWithParsedMessages,
32+
onDisableLogging,
33+
cleanupAfterDisable,
34+
zipRef,
35+
onDownloadZip,
36+
});
3237
}

src/components/RecordTroubleshootDataToolMenu/handleStopRecording.ios.ts

Lines changed: 10 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
import RNFS from 'react-native-fs';
22
import Log from '@libs/Log';
3+
import finalizeStopRecording from './finalizeStopRecording';
34
import type StopRecordingParams from './handleStopRecording.types';
45

56
export default async function handleStopRecording({
@@ -37,11 +38,15 @@ export default async function handleStopRecording({
3738

3839
try {
3940
await RNFS.copyFile(profilePath, newFilePath);
40-
zipRef.current?.file(infoFileName, appInfo);
41-
42-
await onDisableLogging(logsWithParsedMessages);
43-
cleanupAfterDisable();
44-
onDownloadZip?.();
41+
await finalizeStopRecording({
42+
infoFileName,
43+
appInfo,
44+
logsWithParsedMessages,
45+
onDisableLogging,
46+
cleanupAfterDisable,
47+
zipRef,
48+
onDownloadZip,
49+
});
4550

4651
setProfileTracePath?.(newFilePath);
4752
Log.hmmm('[ProfilingToolMenu] file copied successfully');
Lines changed: 19 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -1,26 +1,25 @@
1-
import {Platform} from 'react-native';
2-
import handleStopRecordingAndroid from './handleStopRecording.android';
3-
import handleStopRecordingIOS from './handleStopRecording.ios';
4-
import handleStopRecordingNative from './handleStopRecording.native';
1+
import finalizeStopRecording from './finalizeStopRecording';
52
import type StopRecordingParams from './handleStopRecording.types';
6-
import handleStopRecordingWeb from './handleStopRecording.web';
73

84
type HandleStopRecording = (params: StopRecordingParams) => Promise<void>;
95

10-
const handleStopRecording: HandleStopRecording = (params) => {
11-
if (Platform.OS === 'ios') {
12-
return handleStopRecordingIOS(params);
13-
}
14-
15-
if (Platform.OS === 'android') {
16-
return handleStopRecordingAndroid(params);
17-
}
18-
19-
if (Platform.OS === 'web') {
20-
return handleStopRecordingWeb(params);
21-
}
22-
23-
return handleStopRecordingNative(params);
24-
};
6+
const handleStopRecording: HandleStopRecording = ({
7+
infoFileName,
8+
appInfo,
9+
logsWithParsedMessages,
10+
onDisableLogging,
11+
cleanupAfterDisable,
12+
zipRef,
13+
onDownloadZip,
14+
}) =>
15+
finalizeStopRecording({
16+
infoFileName,
17+
appInfo,
18+
logsWithParsedMessages,
19+
onDisableLogging,
20+
cleanupAfterDisable,
21+
zipRef,
22+
onDownloadZip,
23+
});
2524

2625
export default handleStopRecording;

src/components/RecordTroubleshootDataToolMenu/handleStopRecording.web.ts

Lines changed: 0 additions & 17 deletions
This file was deleted.

0 commit comments

Comments
 (0)