Merge pull request Expensify#73421 from QichenZhu/eslint-9-c

[No QA] ESLint 9 upgrade cleanup

Author: roryabraham

eslint.changed.config.mjs

@@ -0,0 +1,46 @@
+import {defineConfig} from 'eslint/config';
+import mainConfig from './eslint.config.mjs';
+
+const config = defineConfig([
+    ...mainConfig,
+
+    {
+        files: ['**/*.ts', '**/*.tsx'],
+        rules: {
+            '@typescript-eslint/no-deprecated': 'error',
+            'rulesdir/no-default-id-values': 'error',
+            'rulesdir/provide-canBeMissing-in-useOnyx': 'error',
+            'rulesdir/no-unstable-hook-defaults': 'error',
+            'no-restricted-syntax': [
+                'error',
+                {
+                    selector: 'ImportNamespaceSpecifier[parent.source.value=/^@libs/]',
+                    message: 'Namespace imports from @libs are not allowed. Use named imports instead. Example: import { method } from "@libs/module"',
+                },
+                {
+                    selector: 'ImportNamespaceSpecifier[parent.source.value=/^@userActions/]',
+                    message: 'Namespace imports from @userActions are not allowed. Use named imports instead. Example: import { action } from "@userActions/module"',
+                },
+            ],
+        },
+    },
+
+    {
+        files: ['**/libs/**/*.{ts,tsx}'],
+        rules: {
+            'no-restricted-syntax': [
+                'error',
+                {
+                    selector: 'ImportNamespaceSpecifier[parent.source.value=/^\\.\\./]',
+                    message: 'Namespace imports are not allowed. Use named imports instead. Example: import { method } from "../libs/module"',
+                },
+                {
+                    selector: 'ImportNamespaceSpecifier[parent.source.value=/^\\./]',
+                    message: 'Namespace imports are not allowed. Use named imports instead. Example: import { method } from "./libs/module"',
+                },
+            ],
+        },
+    },
+]);
+
+export default config;

eslint.config.changed.js

@@ -269,7 +269,6 @@ const config = defineConfig([
             // Rulesdir specific rules
             'rulesdir/no-default-props': 'error',
             'rulesdir/prefer-type-fest': 'error',
-            'rulesdir/no-multiple-onyx-in-file': 'off',
             'rulesdir/prefer-underscore-method': 'off',
             'rulesdir/prefer-import-module-contents': 'off',
             'rulesdir/no-beta-handler': 'error',
@@ -571,6 +570,7 @@ const config = defineConfig([
         'docs/assets/**/*',
         'web/gtm.js',
         '**/.expo/**/*',
+        '**/.rock/**/*',
         'src/libs/SearchParser/searchParser.js',
         'src/libs/SearchParser/autocompleteParser.js',
         'help/_scripts/**/*',

eslint.config.js eslint.config.mjseslint.config.js renamed to eslint.config.mjs

@@ -1,4 +1,3 @@
-/* eslint-disable @typescript-eslint/await-thenable */
 import fs from 'fs';
 import path from 'path';
 import type {RawSourceMap} from 'source-map';

scripts/combine-web-sourcemaps.ts

@@ -36,7 +36,7 @@ fi
 # Run eslint on the changed files
 if [[ -n "$GIT_DIFF_OUTPUT" ]] ; then
     # shellcheck disable=SC2086 # For multiple files in variable
-    eslint --max-warnings=0 --config ./eslint.config.changed.js $GIT_DIFF_OUTPUT
+    eslint --max-warnings=241 --config ./eslint.changed.config.mjs $GIT_DIFF_OUTPUT
 else
     info "No TypeScript files changed"
 fi

scripts/lintChanged.sh

@@ -3,20 +3,10 @@ import {dismissProductTraining} from '@libs/actions/Welcome';
 import CONST from '@src/CONST';
 import type {TranslationPaths} from '@src/languages/types';
 
-const {
-    CONCIERGE_LHN_GBR,
-    RENAME_SAVED_SEARCH,
-    SCAN_TEST_TOOLTIP,
-    SCAN_TEST_TOOLTIP_MANAGER,
-    SCAN_TEST_CONFIRMATION,
-    OUTSTANDING_FILTER,
-    ACCOUNT_SWITCHER,
-    SCAN_TEST_DRIVE_CONFIRMATION,
-    // eslint-disable-next-line @typescript-eslint/no-unused-vars
-    MULTI_SCAN_EDUCATIONAL_MODAL,
-} = CONST.PRODUCT_TRAINING_TOOLTIP_NAMES;
+const {CONCIERGE_LHN_GBR, RENAME_SAVED_SEARCH, SCAN_TEST_TOOLTIP, SCAN_TEST_TOOLTIP_MANAGER, SCAN_TEST_CONFIRMATION, OUTSTANDING_FILTER, ACCOUNT_SWITCHER, SCAN_TEST_DRIVE_CONFIRMATION} =
+    CONST.PRODUCT_TRAINING_TOOLTIP_NAMES;
 
-type ProductTrainingTooltipName = Exclude<ValueOf<typeof CONST.PRODUCT_TRAINING_TOOLTIP_NAMES>, typeof MULTI_SCAN_EDUCATIONAL_MODAL>;
+type ProductTrainingTooltipName = Exclude<ValueOf<typeof CONST.PRODUCT_TRAINING_TOOLTIP_NAMES>, typeof CONST.PRODUCT_TRAINING_TOOLTIP_NAMES.MULTI_SCAN_EDUCATIONAL_MODAL>;
 
 type ShouldShowConditionProps = {
     shouldUseNarrowLayout: boolean;

src/components/ProductTrainingContext/TOOLTIPS.ts

@@ -12051,7 +12051,8 @@ function checkIfScanFileCanBeRead(
     onFailure: () => void,
 ) {
     if (!receiptFilename || !receiptPath) {
-        return;
+        onFailure();
+        return Promise.resolve();
     }
 
     return readFileAsync(receiptPath.toString(), receiptFilename, onSuccess, onFailure, receiptType);

src/libs/actions/IOU.ts

@@ -410,7 +410,6 @@ function IOURequestStepConfirmation({
         let isScanFilesCanBeRead = true;
 
         Promise.all(
-            // eslint-disable-next-line @typescript-eslint/await-thenable
             transactions.map((item) => {
                 const itemReceiptFilename = getReceiptFilenameFromTransaction(item);
                 const itemReceiptPath = item.receipt?.source;
@@ -421,7 +420,7 @@ function IOURequestStepConfirmation({
                     if (item.receipt) {
                         newReceiptFiles = {...newReceiptFiles, [item.transactionID]: item.receipt};
                     }
-                    return;
+                    return Promise.resolve();
                 }
 
                 const onSuccess = (file: File) => {

src/pages/iou/request/step/IOURequestStepConfirmation.tsx

@@ -241,13 +241,12 @@ function IOURequestStepScan({
         let isAllScanFilesCanBeRead = true;
 
         Promise.all(
-            // eslint-disable-next-line @typescript-eslint/await-thenable
             transactions.map((item) => {
                 const itemReceiptPath = item.receipt?.source;
                 const isLocalFile = isLocalFileFileUtils(itemReceiptPath);
 
                 if (!isLocalFile) {
-                    return;
+                    return Promise.resolve();
                 }
 
                 const onFailure = () => {