Remove @ts-expect-error comments that were reintroduced after the main merge

Author: OlGierd03

src/libs/actions/IOU/Split.ts

@@ -1405,7 +1405,8 @@ function updateSplitTransactions({
     };
 
     // Collect optimistic child transactions to add to the search snapshot (forward split only)
-    const optimisticChildSnapshotEntries: Record<string, OnyxTypes.Transaction> = {};
+    const optimisticChildSnapshotEntries: SearchResultDataType = {};
+    const optimisticChildSnapshotKeys: Array<`${typeof ONYXKEYS.COLLECTION.TRANSACTION}${string}`> = [];
 
     for (const [index, splitExpense] of splitExpenses.entries()) {
         const existingTransactionID = isReverseSplitOperation ? originalTransactionID : splitExpense.transactionID;
@@ -1919,7 +1920,7 @@ function updateSplitTransactions({
         // Collect the optimistic child transaction for snapshot update (forward split only)
         if (!isReverseSplitOperation && optimisticTransactionFromGetMoneyRequest) {
             const childTransactionID = optimisticTransactionFromGetMoneyRequest.transactionID;
-            const transactionKey = `${ONYXKEYS.COLLECTION.TRANSACTION}${childTransactionID}`;
+            const transactionKey: `${typeof ONYXKEYS.COLLECTION.TRANSACTION}${string}` = `${ONYXKEYS.COLLECTION.TRANSACTION}${childTransactionID}`;
             // Use the transaction value from optimisticData if available (it may have merchant fixes applied),
             // otherwise fall back to the raw optimistic transaction
             const transactionUpdate = moneyRequestInformationOnyxData.optimisticData?.find((update) => update.key === transactionKey);
@@ -1928,6 +1929,7 @@ function updateSplitTransactions({
                     ? (transactionUpdate.value as OnyxTypes.Transaction)
                     : optimisticTransactionFromGetMoneyRequest;
             optimisticChildSnapshotEntries[transactionKey] = snapshotTransaction;
+            optimisticChildSnapshotKeys.push(transactionKey);
         }
 
         onyxData.optimisticData?.push(...(moneyRequestInformationOnyxData.optimisticData ?? []), ...(updateMoneyRequestParamsOnyxData.optimisticData ?? []), ...optimisticDataComments);
@@ -2140,20 +2142,19 @@ function updateSplitTransactions({
         }
 
         // Build the snapshot data update: remove original transaction and add child transactions
-        const optimisticSnapshotData: Record<string, OnyxTypes.Transaction | null> = {
+        const optimisticSnapshotData: SearchResultDataType = {
             [`${ONYXKEYS.COLLECTION.TRANSACTION}${originalTransactionID}`]: null,
             ...optimisticChildSnapshotEntries,
         };
 
         // On failure, restore the original transaction and remove the child transactions
-        const failureSnapshotData: Record<string, OnyxTypes.Transaction | null> = {
-            [`${ONYXKEYS.COLLECTION.TRANSACTION}${originalTransactionID}`]: originalTransaction ?? null,
-        };
-        for (const childKey of Object.keys(optimisticChildSnapshotEntries)) {
+        // Initializing as an empty typed object to allow dynamic key assignment resolves TypeScript type inference issue
+        const failureSnapshotData: NullishDeep<SearchResultDataType> = {};
+        failureSnapshotData[`${ONYXKEYS.COLLECTION.TRANSACTION}${originalTransactionID}`] = originalTransaction ?? null;
+        for (const childKey of optimisticChildSnapshotKeys) {
             failureSnapshotData[childKey] = null;
         }
 
-        // @ts-expect-error - will be solved in https://github.com/Expensify/App/issues/73830
         onyxData.optimisticData?.push({
             onyxMethod: Onyx.METHOD.MERGE,
             key: `${ONYXKEYS.COLLECTION.SNAPSHOT}${searchContext?.currentSearchHash}`,
@@ -2162,7 +2163,6 @@ function updateSplitTransactions({
             },
         });
 
-        // @ts-expect-error - will be solved in https://github.com/Expensify/App/issues/73830
         onyxData.failureData?.push({
             onyxMethod: Onyx.METHOD.MERGE,
             key: `${ONYXKEYS.COLLECTION.SNAPSHOT}${searchContext?.currentSearchHash}`,