From 6b27d2864c72a5aac0bd5f0143b59c91084971ea Mon Sep 17 00:00:00 2001 From: donlaiq Date: Sun, 16 Jun 2024 11:15:27 -0300 Subject: [PATCH 1/3] Update Chart.js Using the total sum instead of the max value. --- code/06-finished/src/components/Chart/Chart.js | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/code/06-finished/src/components/Chart/Chart.js b/code/06-finished/src/components/Chart/Chart.js index e9fb675880..482eb8f7bf 100644 --- a/code/06-finished/src/components/Chart/Chart.js +++ b/code/06-finished/src/components/Chart/Chart.js @@ -4,8 +4,9 @@ import ChartBar from './ChartBar'; import './Chart.css'; const Chart = (props) => { - const dataPointValues = props.dataPoints.map(dataPoint => dataPoint.value); - const totalMaximum = Math.max(...dataPointValues); + let total = 0; + for(let v of props.dataPoints) + total += parseFloat(v.value); return (
@@ -13,7 +14,7 @@ const Chart = (props) => { ))} From afbc6b8ede8b340de69677a9cdf723d36854d5b5 Mon Sep 17 00:00:00 2001 From: donlaiq Date: Sun, 16 Jun 2024 11:19:29 -0300 Subject: [PATCH 2/3] Update ChartBar.js Updating totalValue. --- code/06-finished/src/components/Chart/ChartBar.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/code/06-finished/src/components/Chart/ChartBar.js b/code/06-finished/src/components/Chart/ChartBar.js index 006be7eb0a..6a4b691656 100644 --- a/code/06-finished/src/components/Chart/ChartBar.js +++ b/code/06-finished/src/components/Chart/ChartBar.js @@ -5,8 +5,8 @@ import './ChartBar.css'; const ChartBar = (props) => { let barFillHeight = '0%'; - if (props.maxValue > 0) { - barFillHeight = Math.round((props.value / props.maxValue) * 100) + '%'; + if (props.totalValue > 0) { + barFillHeight = Math.round((props.value / props.totalValue) * 100) + '%'; } return ( From 73b6351dec3da6f166a8d9bc207f4b2bca673ef6 Mon Sep 17 00:00:00 2001 From: donlaiq Date: Sun, 16 Jun 2024 11:20:21 -0300 Subject: [PATCH 3/3] Update Chart.js Changing variable name to toalValue. --- code/06-finished/src/components/Chart/Chart.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/code/06-finished/src/components/Chart/Chart.js b/code/06-finished/src/components/Chart/Chart.js index 482eb8f7bf..5c8d97c201 100644 --- a/code/06-finished/src/components/Chart/Chart.js +++ b/code/06-finished/src/components/Chart/Chart.js @@ -14,7 +14,7 @@ const Chart = (props) => { ))}