...
- One nit (not blocking): the JSON branch has a redundant
persistence: isAuthed ? {...} : { enabled: !!STATS_FILE } ternary inside the ...(isAuthed ? {...} : {}) spread, since the outer condition already guarantees isAuthed. Same with the inner sessions: isAuthed ? ... : ... and pskMqttProxy.activeCallsigns: isAuthed ? ... : .... Could be cleaned up next time you touch the file.
Originally posted by @accius in #940 (review)
please assign to @MichaelWheeley I'm not able to self-assign
...
persistence: isAuthed ? {...} : { enabled: !!STATS_FILE }ternary inside the...(isAuthed ? {...} : {})spread, since the outer condition already guaranteesisAuthed. Same with the innersessions: isAuthed ? ... : ...andpskMqttProxy.activeCallsigns: isAuthed ? ... : .... Could be cleaned up next time you touch the file.Originally posted by @accius in #940 (review)
please assign to @MichaelWheeley I'm not able to self-assign