Skip to content

Commit a8c75bd

Browse files
authored
chore(ci): remove redundant if conditions in build-and-publish workflow (#455)
The workflow only triggers on pushes to the master branch, so checking github.ref == 'refs/heads/master' on individual steps is always true and therefore redundant. Closes #454 Signed-off-by: Shubh-Raj <shubhraj625@gmail.com>
1 parent fae3dd4 commit a8c75bd

File tree

1 file changed

+1
-4
lines changed

1 file changed

+1
-4
lines changed

.github/workflows/build-and-publish.yml

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -28,15 +28,12 @@ jobs:
2828
node-version: ${{ matrix.node-version }}
2929

3030
- name: NPM Install
31-
if: github.ref == 'refs/heads/master'
3231
run: npm install
3332

3433
- name: NPM Build
35-
if: github.ref == 'refs/heads/master'
3634
run: npm run build
3735

3836
- name: Set S3
39-
if: github.ref == 'refs/heads/master'
4037
run: |
4138
echo "AWS_S3_BUCKET=${{secrets.AWS_S3_BUCKET}}" >> $GITHUB_ENV
4239
@@ -52,4 +49,4 @@ jobs:
5249
env:
5350
DISTRIBUTION: ${{ secrets.AWS_CLOUDFRONT_DISTRIBUTION_ID }}
5451
PATHS: '/*'
55-
AWS_REGION: ${{ secrets.AWS_REGION }}
52+
AWS_REGION: ${{ secrets.AWS_REGION }}

0 commit comments

Comments
 (0)