fix(cicero-core): add missing await on updateExternalModels in fromAr… (#878)

Author: Divyansh2992

packages/cicero-core/src/templateloader.js

@@ -90,15 +90,15 @@ class TemplateLoader {
         // add model files
         Logger.debug(method, 'Adding model files to model manager');
         const mm = template.getModelManager();
-        ctoModelFiles.forEach( (mf,index) => {
+        ctoModelFiles.forEach((mf, index) => {
             mm.addCTOModel(mf, ctoModelFileNames[index], true);
         });
 
-        if(options && options.offline) {
+        if (options && options.offline) {
             mm.validateModelFiles();
         }
         else {
-            mm.updateExternalModels();
+            await mm.updateExternalModels();
         }
 
         Logger.debug(method, 'Setting grammar');
@@ -193,7 +193,7 @@ class TemplateLoader {
         const mm = template.getModelManager();
         mm.addModelFiles(modelFiles, modelFileNames, true);
 
-        if(options && options.offline) {
+        if (options && options.offline) {
             mm.validateModelFiles();
         }
         else {
@@ -202,7 +202,7 @@ class TemplateLoader {
 
         if (!options || !options.offline) {
             mm.getModelFiles().forEach(mf => {
-                if(mf.isExternal()) {
+                if (mf.isExternal()) {
                     fs.writeFileSync(path + '/model/' + mf.getName(), mf.getDefinitions());
                 }
             });
@@ -223,7 +223,7 @@ class TemplateLoader {
         tsFiles.forEach((file) => {
             const resolvedPath = slash(fsPath.resolve(path));
             const resolvedFilePath = slash(fsPath.resolve(file.name));
-            const truncatedPath = resolvedFilePath.replace(resolvedPath+'/', '');
+            const truncatedPath = resolvedFilePath.replace(resolvedPath + '/', '');
             template.getLogicManager().addLogicFile(file.contents, truncatedPath);
             Logger.debug(method, `Loaded ${truncatedPath}`, file.contents);
         });

packages/cicero-core/test/template.js

@@ -368,6 +368,36 @@ describe('Template', () => {
             const template2 = await Template.fromArchive(buffer);
             template2.getMetadata().getLogo().should.be.an.instanceof(Buffer);
         });
+
+        it('should await updateExternalModels before returning from fromArchive', async () => {
+            const { ModelManager } = require('@accordproject/concerto-core');
+
+            // Build a buffer offline so no network call during setup
+            const source = await Template.fromDirectory('./test/data/latedeliveryandpenalty', { offline: true });
+            const buffer = await source.toArchive('es6');
+
+            // Patch updateExternalModels with an async spy that sets a flag when resolved
+            let externalModelsResolved = false;
+            const original = ModelManager.prototype.updateExternalModels;
+            ModelManager.prototype.updateExternalModels = async function () {
+                // Simulate a small async delay (e.g. network call)
+                await new Promise(resolve => setTimeout(resolve, 50));
+                externalModelsResolved = true;
+            };
+
+            try {
+                // Call fromArchive without offline flag — should hit updateExternalModels path
+                await Template.fromArchive(buffer);
+            } finally {
+                ModelManager.prototype.updateExternalModels = original;
+            }
+
+            // If fromArchive correctly awaits updateExternalModels, the flag must be true here
+            assert.isTrue(
+                externalModelsResolved,
+                'fromArchive() must await updateExternalModels() before returning'
+            );
+        });
     });
 
     describe('#fromCompiledArchive', () => {