Test with Concerto v4

[mttrbrts]

Feature Request 🛍️

Concerto v4 is in beta. To help validate the prerelease build, upgrade the use of Concerto in this repo to use the new API and record the steps required and any issues for feedback to the Concerto maintainers.

Use Case

Possible Solution

Context

Detailed Description

https://github.com/accordproject/concerto/releases/tag/untagged-38736002f7f2ffcc3b89
accordproject/concerto#762

[vermarjun]

Hi, I have started working on this issue. Thanks!

[hemantch01]

What Changed

• Updated Concerto dependencies to 4.0.0-beta.1 in:

  • packages/cicero-core
    • @accordproject/concerto-core: 3.25.7 → 4.0.0-beta.1
    • @accordproject/concerto-util: 3.25.7 → 4.0.0-beta.1
  • packages/cicero-cli
    • @accordproject/concerto-util: 3.25.7 → 4.0.0-beta.1

• Updated local .cto model files across packages/**:

  • Changed concerto version "^3.0.0" → concerto version ">=3.0.0".

• Added a compatibility shim in packages/cicero-core/src/logicmanager.js to prevent incorrect version detection caused by process.env.npm_package_version during workspace tests.

---

Results

• cicero-cli tests: PASS (45 passing, 1 pending)
• cicero-core tests: FAIL (113 passing, 7 pending, 54 failing)

---

Observed Issues for Maintainers

1. Install-time script failure

   • npm install fails due to @accordproject/concerto-metamodel@3.12.8 running lockfile-lint, which is not available.
   • Error: sh: 1: lockfile-lint: not found
   • Temporary workaround: npm install --ignore-scripts.

2. Version detection tied to npm_package_version

   • Concerto v4 compatibility checks rely on process.env.npm_package_version.
   • In workspace tests this resolves to the host package version (0.25.0), causing false incompatibility errors.

3. External models still pinned to Concerto ^3

   • Models fetched via updateExternalModels still declare concerto version "^3.0.0".
   • This causes failures such as:

     ModelFile expects Concerto version ^3.0.0 but this is 4.0.0-beta.1
     

• Above error was also occured in @accordproject/template-playground

4. Strict import validation
   • Concerto v4 rejects previously accepted unversioned imports.
   • Example:

     Cannot use an unversioned import org.accordproject.contract.
     

[mttrbrts]

Good feedback @hemantch01, thanks for the investigation and writeup.

If anyone here wants to work on the issues that you've found please create an issue (in the relevant repo) and assign yourself before working to avoid duplication.

[vermarjun]

Building on the findings already posted, here are additional technical details and one new issue not yet documented.

---

Additional Detail: Version Check Tied to npm_package_version

Exact error:

Error: ModelFile expects Concerto version ^3.0.0 but this is 0.25.0

Exact origin: node_modules/@accordproject/concerto-core/dist/introspect/modelfile.js:602:23 at ModelFile.isCompatibleVersion

Callers:

• test/clause.js:33:30: during TemplateLoader.fromDirectory
• test/template.js:103:30: during TemplateLoader.fromDirectory

This error is the root cause of 55 out of 57 test failures. Because it crashes TemplateLoader during test setup, deeper breaking changes are currently obscured and cannot be observed until this is resolved.

---

New Issue: Strict Rejection of Unversioned Namespaces

This is separate from unversioned imports, not yet documented.

Exact error:

Error: Cannot add an unversioned namespace: org.accordproject.copyrightlicense

Exact origin: node_modules/@accordproject/concerto-core/dist/basemodelmanager.js:210:19 at ModelManager.addModelFile

Callers:

• test/logicmanager.js:42:62
• test/script.js:35:22

Any CTO file using namespace org.accordproject.x without a semver suffix (e.g. @1.0.0) is now rejected by v4. This is distinct from the unversioned imports issue, it applies to the namespace declarations themselves.

---

Reproduce All Findings

cd packages/cicero-core
# bump concerto-core and concerto-util to 4.0.0-beta.1 in package.json
rm -rf node_modules package-lock.json
npm install --ignore-scripts
npm run test:mocha

---

Still actively working on this, will follow up with a PR containing full findings and fixes once the deeper errors are unblocked.