Merge branch 'main' into fix/ai-chat-buffer

Author: 23harshitkumar

.github/workflows/build-and-publish.yml

@@ -36,7 +36,7 @@ jobs:
         run: npm ci
 
       - name: NPM Build
-        run: SERVER_ROOT=https://playground.accordproject.org && NODE_OPTIONS=--max_old_space_size=8192 npm run build
+        run: SERVER_ROOT=https://playground.accordproject.org NODE_OPTIONS=--max_old_space_size=8192 npm run build
         if: github.ref == 'refs/heads/main'
 
       - name: Set S3 

.github/workflows/pr-check.yml

@@ -33,4 +33,4 @@ jobs:
         run: npm ci
 
       - name: NPM Build
-        run: SERVER_ROOT=https://playground.accordproject.org && NODE_OPTIONS=--max_old_space_size=8192 npm run build
+        run: SERVER_ROOT=https://playground.accordproject.org NODE_OPTIONS=--max_old_space_size=8192 npm run build

.github/workflows/test.yml

@@ -10,7 +10,7 @@ on:
 
 concurrency:
   group: ${{ github.workflow }}-${{ github.event.pull_request.number || github.ref }}
-  cancel-in-progress: true
+  cancel-in-progress: ${{ github.event_name == 'pull_request' }}
 
 jobs:
   build:

e2e/app.spec.ts

@@ -43,7 +43,7 @@ test.describe('App Loading', () => {
 });
 
 test.describe('Dark Mode', () => {
-  test('should toggle dark mode', async ({ page }) => {
+  test('should toggle dark mode via Settings modal', async ({ page }) => {
     await page.goto('/');
     await expect(page.locator('.app-spinner-container')).toBeHidden({ timeout: 30000 });
 
@@ -52,13 +52,37 @@ test.describe('Dark Mode', () => {
       document.documentElement.getAttribute('data-theme')
     );
 
-    // Find the dark mode toggle - assert it exists
-    const darkModeToggle = page.locator('[data-testid="toggle-dark-mode"]');
-    await expect(darkModeToggle, 'Dark mode toggle should be visible').toBeVisible();
+    // Open Settings modal - the gear icon button in sidebar
+    const settingsButton = page.getByRole('button', { name: 'Settings' });
+    await expect(settingsButton).toBeVisible();
+    await settingsButton.click();
 
-    // Click the toggle
+    // Wait for the Settings modal to appear
+    const settingsModal = page.getByRole('dialog');
+    await expect(settingsModal).toBeVisible({ timeout: 5000 });
+
+    // Find and click the Dark Mode toggle inside the modal
+    // The react-dark-mode-toggle library renders a button element
+    // Find the section containing "Dark Mode" text, then locate the button within it
+    const darkModeSection = settingsModal.locator('div').filter({ hasText: /^Dark Mode/ }).first();
+    const darkModeToggle = darkModeSection.locator('button').first();
+    await expect(darkModeToggle, 'Dark mode toggle should be visible in Settings modal').toBeVisible();
     await darkModeToggle.click();
 
+    // Close the modal
+    const closeButton = settingsModal.getByRole('button', { name: /close/i }).or(
+      settingsModal.locator('[aria-label="Close"]')
+    );
+    if (await closeButton.isVisible()) {
+      await closeButton.click();
+    } else {
+      // Press Escape to close modal
+      await page.keyboard.press('Escape');
+    }
+
+    // Wait for modal to close
+    await expect(settingsModal).toBeHidden({ timeout: 3000 });
+
     // Theme should change
     const newTheme = await page.evaluate(() => 
       document.documentElement.getAttribute('data-theme')

index.html

@@ -5,7 +5,7 @@
     <link
       rel="icon"
       type="image"
-      href="https://i0.wp.com/accordproject.org/wp-content/uploads/2020/08/cropped-ms-icon-310x310-1.png?fit=512%2C512&ssl=1"
+      href="/favicon.webp"
     />
     <meta
       name="viewport"
@@ -15,7 +15,7 @@
     <meta property="og:description" content="Template Playground" />
     <meta
       property="og:image"
-      content="https://i0.wp.com/accordproject.org/wp-content/uploads/2020/08/cropped-ms-icon-310x310-1.png?fit=512%2C512&ssl=1"
+      content="/favicon.webp"
     />
     <meta property="og:url" content="https://playground.accordproject.org/" />
     <title>Template Playground</title>