Skip to content

Commit 0254ec0

Browse files
authored
[Feedback] Fix typo in getSummaryOfThreads (#8889)
This fixes the BVL Feedback summary in instruments by taking the commentID for query params from the array _feedbackObjectInfo instead of _feedbackCandidateProfileInfo, which only included candidate specific data instead of instrument specific data.
1 parent cc6f1e8 commit 0254ec0

File tree

2 files changed

+2
-1
lines changed

2 files changed

+2
-1
lines changed

CHANGELOG.md

+1
Original file line numberDiff line numberDiff line change
@@ -166,6 +166,7 @@ the `Data` key instead of `$InstrumentName` (PR #7857)
166166
- Fixed broken DB calls in `assign_missing_instruments` and `instruments` (PR #8162)
167167
- Add support for PHP 8.1 (PR #7989)
168168
- Fix Project tab of Configuration module to give correct errors, and prevent saving without Alias (PR #8349)
169+
- Fix BVL feedback summary in instruments (PR #8889)
169170
### Modules
170171
#### API
171172
- Ability to use PSCID instead of the CandID in the candidates API (PR #8138)

php/libraries/NDB_BVL_Feedback.class.inc

+1-1
Original file line numberDiff line numberDiff line change
@@ -499,7 +499,7 @@ class NDB_BVL_Feedback
499499
}
500500
if (!empty($this->_feedbackObjectInfo['CommentID'])) {
501501
$query .= " AND ft.CommentID = :ComID";
502-
$qparams['ComID'] = $this->_feedbackCandidateProfileInfo['CommentID'];
502+
$qparams['ComID'] = $this->_feedbackObjectInfo['CommentID'];
503503
}
504504

505505
if (!$hasReadPermission) {

0 commit comments

Comments
 (0)