Merge pull request jackc#2506 from JelteF/skip-standard-conforming-strings

Skip standard_conforming_strings=off on PG19

Author: jackc

pgxtest/pgxtest.go

@@ -171,3 +171,21 @@ func SkipPostgreSQLVersionLessThan(t testing.TB, conn *pgx.Conn, minVersion int6
 		t.Skipf("Test requires PostgreSQL v%d+", minVersion)
 	}
 }
+
+func SkipPostgreSQLVersionGreaterThan(t testing.TB, conn *pgx.Conn, maxVersion int64) {
+	serverVersionStr := conn.PgConn().ParameterStatus("server_version")
+	serverVersionStr = regexp.MustCompile(`^[0-9]+`).FindString(serverVersionStr)
+	// if not PostgreSQL do nothing
+	if serverVersionStr == "" {
+		return
+	}
+
+	serverVersion, err := strconv.ParseInt(serverVersionStr, 10, 64)
+	if err != nil {
+		t.Fatalf("postgres version parsed failed: %s", err)
+	}
+
+	if serverVersion > maxVersion {
+		t.Skipf("Test requires PostgreSQL v%d or lower", maxVersion)
+	}
+}

query_test.go

@@ -2033,6 +2033,7 @@ func TestConnSimpleProtocolRefusesNonStandardConformingStrings(t *testing.T) {
 	defer closeConn(t, conn)
 
 	pgxtest.SkipCockroachDB(t, conn, "Server does not support standard_conforming_strings = off (https://github.com/cockroachdb/cockroach/issues/36215)")
+	pgxtest.SkipPostgreSQLVersionGreaterThan(t, conn, 18) // PG19 stopped supporting standard_conforming_strings = off
 
 	mustExec(t, conn, "set standard_conforming_strings to off")