refactor: move custom packages into flake

Author: Defelo

.github/workflows/review.yml

@@ -139,7 +139,8 @@ jobs:
         with:
           sparse-checkout: |
             .github/actions
-            packages.nix
+            flake.lock
+            flake.nix
 
       - name: setup nix
         uses: ./.github/actions/setup-nix
@@ -160,7 +161,7 @@ jobs:
           elif [[ ${{ inputs.push-to-cache && vars.CACHIX_CACHE != '' }} = true ]]; then
             pkgs+=(cachix)
           fi
-          nix profile add -f packages.nix ${pkgs[@]}
+          nix profile add "${pkgs[@]/#/.#}"
 
       - name: clone nixpkgs
         uses: actions/checkout@v4

flake.lock

@@ -1,24 +1,37 @@
 {
   inputs = {
     nixpkgs.url = "github:NixOS/nixpkgs/nixpkgs-unstable";
+    nixpkgs-review.url = "github:Mic92/nixpkgs-review";
   };
 
   outputs =
-    { self, nixpkgs }:
+    {
+      self,
+      nixpkgs,
+      nixpkgs-review,
+    }:
 
     let
       inherit (nixpkgs) lib;
 
-      eachSystem = f: lib.genAttrs systems (s: f nixpkgs.legacyPackages.${s});
+      eachSystem = f: lib.genAttrs systems (system: f (import nixpkgs { inherit system overlays; }));
       systems = [
         "x86_64-linux"
         "aarch64-linux"
         "x86_64-darwin"
         "aarch64-darwin"
       ];
+
+      overlays = [ self.overlays.nixpkgs-review ];
     in
 
     {
+      overlays.nixpkgs-review = final: prev: {
+        inherit (nixpkgs-review.packages.${final.system}) nixpkgs-review;
+      };
+
+      legacyPackages = eachSystem lib.id;
+
       formatter = eachSystem (
         pkgs:
         pkgs.treefmt.withConfig {
@@ -30,6 +43,7 @@
       );
 
       checks = eachSystem (pkgs: {
+        inherit (pkgs) nixpkgs-review;
         fmt = pkgs.runCommandNoCCLocal "fmt-check" { } ''
           cp -r --no-preserve=mode ${self} repo
           ${lib.getExe self.formatter.${pkgs.system}} -C repo --ci