Fix auto quote-conversion when converting into BibTeX + add tests #5195
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5195 +/- ##
==========================================
- Coverage 92.57% 92.57% -0.01%
==========================================
Files 32 32
Lines 2304 2303 -1
==========================================
- Hits 2133 2132 -1
Misses 171 171
🚀 New features to boost your workflow:
|
nschneid
reviewed
May 19, 2025
|
Build successful. Some useful links:
This preview will be removed when the branch is merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should fix #5146
The
latex_convert_quotesfunction is a bit esoteric and I believe the way it should work has shifted due to changes in the BibTeX generation pipeline. We didn't have many test cases for this either, so I added some, and modified the code to make them pass.