get rid of ScikitLearn and packages check#73
Merged
PasoStudio73 merged 16 commits intomainfrom Jul 24, 2025
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #73 +/- ##
==========================================
+ Coverage 90.29% 95.65% +5.35%
==========================================
Files 8 8
Lines 402 437 +35
==========================================
+ Hits 363 418 +55
+ Misses 39 19 -20 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
the deps from ScikitLearn is unused here in SoleXplorer, but should stay because compatibility with SolePostHoc.
Now, since SolePostHoc no longer needs ScikitLearn, it's safe to remove the deps also in SoleXplorer.
Then would be nice to check if we can merge devs branches from SoleBase and SoleModels into their own main, to remove their sources deps, leaving only ModalDecisionTrees and SolePostHoc still in dev