Skip to content

get rid of ScikitLearn and packages check#73

Merged
PasoStudio73 merged 16 commits intomainfrom
devPaso
Jul 24, 2025
Merged

get rid of ScikitLearn and packages check#73
PasoStudio73 merged 16 commits intomainfrom
devPaso

Conversation

@PasoStudio73
Copy link
Member

the deps from ScikitLearn is unused here in SoleXplorer, but should stay because compatibility with SolePostHoc.
Now, since SolePostHoc no longer needs ScikitLearn, it's safe to remove the deps also in SoleXplorer.
Then would be nice to check if we can merge devs branches from SoleBase and SoleModels into their own main, to remove their sources deps, leaving only ModalDecisionTrees and SolePostHoc still in dev

@PasoStudio73 PasoStudio73 self-assigned this Jul 18, 2025
@PasoStudio73 PasoStudio73 added the enhancement New feature or request label Jul 18, 2025
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review any files in this pull request.

@codecov
Copy link

codecov bot commented Jul 18, 2025

Codecov Report

❌ Patch coverage is 99.16667% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 95.65%. Comparing base (4c8d8f3) to head (cb96cd1).
⚠️ Report is 22 commits behind head on main.

Files with missing lines Patch % Lines
src/partition.jl 91.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #73      +/-   ##
==========================================
+ Coverage   90.29%   95.65%   +5.35%     
==========================================
  Files           8        8              
  Lines         402      437      +35     
==========================================
+ Hits          363      418      +55     
+ Misses         39       19      -20     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@PasoStudio73 PasoStudio73 merged commit 79a856e into main Jul 24, 2025
4 checks passed
@github-project-automation github-project-automation bot moved this to Done in SOLE Jul 24, 2025
@PasoStudio73 PasoStudio73 deleted the devPaso branch July 24, 2025 19:52
@PasoStudio73 PasoStudio73 restored the devPaso branch July 29, 2025 22:08
@PasoStudio73 PasoStudio73 deleted the devPaso branch August 13, 2025 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

1 participant