Conversation
Closed
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #76 +/- ##
==========================================
+ Coverage 95.67% 95.85% +0.18%
==========================================
Files 8 8
Lines 439 531 +92
==========================================
+ Hits 420 509 +89
- Misses 19 22 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
giopaglia
reviewed
Aug 14, 2025
giopaglia
reviewed
Aug 14, 2025
Member
There was a problem hiding this comment.
(Is it the case that this is not needed anymore because there are CI automations for building the documentation?)
Member
There was a problem hiding this comment.
I've updated the comment, maybe it was not so clear
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now that Lumen algorhitm in SolePostHoc package is almost ready, we should rething its integration in SoleXplorer.
How SolePostHoc is linked to SoleXplorer is actually a little hacked: you can find that hack in devPaso branch of SolePostHoc repo.
Asking for SolePostHoc mods to satisfy SoleXplorer user interface it's a little bit tricky and out of context, I think.
Better to refactor SoleXplorer->SolePostHoc interface to allow an easy user experience interface and mainain the complexity that a weapon like SolePostHoc demand.