chore: update Mongoose from 8.x to 9.x

Merge pull request #32 from net-escape/copilot/update-mongoose-dependency-backend

Author: luoingly

backend/package.json

@@ -44,7 +44,7 @@
     "koa-session": "^7.0.2",
     "koa-static": "^5.0.0",
     "lodash": "^4.17.21",
-    "mongoose": "^8.20.4",
+    "mongoose": "^9.0.2",
     "mongoose-paginate-v2": "^1.9.1",
     "pm2": "^6.0.14",
     "superagent": "^10.2.3",

backend/src/controllers/contest.ts

@@ -108,7 +108,7 @@ const findContests = async (ctx: Context) => {
     if (role.manageContest) {
       showAll = true
     }
-    courseDocId = course.id
+    courseDocId = course._id
   }
 
   const paginateOption = parsePaginateOption(opt, 20)
@@ -217,7 +217,7 @@ const createContest = async (ctx: Context) => {
   let courseDocId: Types.ObjectId | undefined
   if (opt.course) {
     const { course } = await loadCourse(ctx, opt.course)
-    courseDocId = course.id
+    courseDocId = course._id
   }
 
   try {
@@ -258,7 +258,7 @@ const updateContest = async (ctx: Context) => {
       courseDocId = null
     } else {
       const { course } = await loadCourse(ctx, opt.course)
-      courseDocId = course.id
+      courseDocId = course._id
     }
   }
 

backend/src/controllers/course.ts

@@ -105,7 +105,7 @@ const joinCourse = async (ctx: Context) => {
 
   const profile = await loadProfile(ctx)
   const result = await courseService.updateCourseMember(
-    course.id, profile.id,
+    course._id, profile._id,
     { ...role, basic: true },
   )
 
@@ -166,7 +166,7 @@ const findCourseMembers = async (ctx: Context) => {
   const { page, pageSize } = parsePaginateOption(opt, 30, 200)
 
   const response: Paginated<CourseMemberView>
-    = await courseService.findCourseMembers(course.id, { page, pageSize })
+    = await courseService.findCourseMembers(course._id, { page, pageSize })
   ctx.body = response
 }
 
@@ -181,7 +181,7 @@ const getCourseMember = async (ctx: Context) => {
     return ctx.throw(400, 'Missing uid')
   }
 
-  const member = await courseService.getCourseMember(course.id, userId)
+  const member = await courseService.getCourseMember(course._id, userId)
   if (!member) {
     return ctx.throw(...ERR_NOT_FOUND)
   }
@@ -227,8 +227,8 @@ const updateCourseMember = async (ctx: Context) => {
   }
 
   const result = await courseService.updateCourseMember(
-    course.id,
-    user.id,
+    course._id,
+    user._id,
     newRole as CourseRole,
   )
   ctx.auditLog.info(`<Course:${course.courseId}> member <User:${userId}> updated by <User:${profile.uid}>`)
@@ -251,7 +251,7 @@ const removeCourseMember = async (ctx: Context) => {
     return ctx.throw(400, 'Cannot remove yourself from the course')
   }
 
-  const result = await courseService.removeCourseMember(course.id, userId)
+  const result = await courseService.removeCourseMember(course._id, userId)
   const response: { success: boolean } = { success: result }
   ctx.auditLog.info(`<Course:${course.courseId}> member <User:${userId}> removed by <User:${profile.uid}>`)
   ctx.body = response
@@ -269,7 +269,7 @@ const addCourseProblems = async (ctx: Context) => {
     if (!problem) {
       return false
     }
-    return await courseService.addCourseProblem(course.id, problem.id)
+    return await courseService.addCourseProblem(course._id, problem._id)
   }))
 
   const successCount = result.filter(v => v).length
@@ -291,15 +291,15 @@ const moveCourseProblem = async (ctx: Context) => {
     return ctx.throw(...ERR_INVALID_ID)
   }
   const result = await courseService.moveCourseProblem(
-    course.id, problem.id, beforePos,
+    course._id, problem._id, beforePos,
   )
   ctx.body = { success: result }
 }
 
 const rearrangeCourseProblem = async (ctx: Context) => {
   const { course } = await loadCourse(ctx)
   try {
-    await courseService.rearrangeCourseProblem(course.id)
+    await courseService.rearrangeCourseProblem(course._id)
     ctx.body = { success: true }
   } catch (e: any) {
     ctx.throw(500, `Failed to rearrange course problems: ${e.message}`)
@@ -313,7 +313,7 @@ const removeCourseProblem = async (ctx: Context) => {
   if (!problem) {
     return ctx.throw(...ERR_INVALID_ID)
   }
-  const result = await courseService.removeCourseProblem(course.id, problem.id)
+  const result = await courseService.removeCourseProblem(course._id, problem._id)
   const profile = await loadProfile(ctx)
   ctx.auditLog.info(`<Course:${course.courseId}> removed <Problem:${problemId}> by <User:${profile.uid}>`)
   ctx.body = { success: result }

backend/src/controllers/problem.ts

@@ -74,7 +74,7 @@ export async function loadProblem (
   }
 
   if (profile && await courseService.hasProblemRole(
-    profile.id, problem.id, 'basic',
+    profile._id, problem._id, 'basic',
   )) {
     ctx.state.problem = problem
     return problem
@@ -125,14 +125,14 @@ const findProblems = async (ctx: Context) => {
         ...paginateOption,
         ...filterOption,
         showReserved,
-        includeOwner: profile?.id ?? null,
+        includeOwner: profile?._id ?? null,
       },
     )
   }
   list.docs = list.docs.map(doc => ({
     ...doc,
-    isOwner: profile?.id && doc.owner
-      ? doc.owner.toString() === profile.id.toString()
+    isOwner: profile?._id && doc.owner
+      ? doc.owner.equals(profile._id)
       : false,
     owner: undefined,
   }))
@@ -190,8 +190,8 @@ const getProblem = async (ctx: Context) => {
   const problem = await loadProblem(ctx)
   const profile = ctx.state.profile
 
-  const isOwner = (profile?.id && problem.owner)
-    ? profile.id.toString() === problem.owner.toString()
+  const isOwner = (profile?._id && problem.owner)
+    ? problem.owner.equals(profile._id)
     : false
   const canManage = profile?.isAdmin ?? isOwner
 
@@ -236,7 +236,7 @@ const createProblem = async (ctx: Context) => {
       owner,
     })
     if (course) {
-      await courseService.addCourseProblem(course.id, problem.id)
+      await courseService.addCourseProblem(course._id, problem._id)
     }
     ctx.auditLog.info(`<Problem:${problem.pid}> created by <User:${profile.uid}>`)
     const response: Pick<ProblemEntity, 'pid'>

backend/src/controllers/solution.ts

@@ -104,7 +104,7 @@ const create = async (ctx: Context) => {
       ctx.throw(400, 'No such a problem in the contest')
     }
     if (contest.course) {
-      course = contest.course.id
+      course = contest.course._id
     }
   }
   const problem = await Problem.findOne({ pid })
@@ -115,7 +115,7 @@ const create = async (ctx: Context) => {
    * @TODO
    */
   // if (problem.course && !course) {
-  //   course = problem.course.id
+  //   course = problem.course._id
   // }
 
   try {

backend/src/controllers/testcase.ts

@@ -16,7 +16,7 @@ import { loadProblem } from './problem'
 export async function findTestcases (ctx: Context) {
   const problem = await loadProblem(ctx)
   const profile = await loadProfile(ctx)
-  if (!(profile.isAdmin || (problem.owner && problem.owner === profile.id))) {
+  if (!(profile.isAdmin || (problem.owner && problem.owner.equals(profile._id)))) {
     ctx.throw(...ERR_PERM_DENIED)
   }
 
@@ -40,9 +40,9 @@ export async function exportTestcases (ctx: Context) {
   const profile = await loadProfile(ctx)
   if (!(
     profile.isAdmin
-    || (problem.owner && problem.owner === profile.id)
+    || (problem.owner && problem.owner.equals(profile._id))
     || courseService.hasProblemRole(
-      profile.id, problem.id, 'viewTestcase',
+      profile._id, problem._id, 'viewTestcase',
     )
   )) {
     ctx.throw(...ERR_PERM_DENIED)
@@ -104,7 +104,7 @@ export async function exportTestcases (ctx: Context) {
 export async function createTestcase (ctx: Context) {
   const problem = await loadProblem(ctx)
   const profile = await loadProfile(ctx)
-  if (!(profile.isAdmin || (problem.owner && problem.owner === profile.id))) {
+  if (!(profile.isAdmin || (problem.owner && problem.owner.equals(profile._id)))) {
     ctx.throw(...ERR_PERM_DENIED)
   }
 
@@ -147,7 +147,7 @@ export async function createTestcase (ctx: Context) {
 export async function removeTestcase (ctx: Context) {
   const problem = await loadProblem(ctx)
   const profile = await loadProfile(ctx)
-  if (!(profile.isAdmin || (problem.owner && problem.owner === profile.id))) {
+  if (!(profile.isAdmin || (problem.owner && problem.owner.equals(profile._id)))) {
     ctx.throw(...ERR_PERM_DENIED)
   }
 
@@ -180,9 +180,9 @@ export async function getTestcase (ctx: Context) {
   const profile = await loadProfile(ctx)
   if (!(
     profile.isAdmin
-    || (problem.owner && problem.owner === profile.id)
+    || (problem.owner && problem.owner.equals(profile._id))
     || courseService.hasProblemRole(
-      profile.id, problem.id, 'viewTestcase',
+      profile._id, problem._id, 'viewTestcase',
     )
   )) {
     ctx.throw(...ERR_PERM_DENIED)

backend/src/models/Comment.ts

@@ -41,11 +41,10 @@ const commentSchema = new mongoose.Schema({
   timestamps: true,
 })
 
-commentSchema.pre('save', async function (next) {
+commentSchema.pre('save', async function () {
   if (this.commentId === -1) {
     this.commentId = await ID.generateId('Comment')
   }
-  next()
 })
 
 const Comment

backend/src/models/Contest.ts

@@ -108,17 +108,15 @@ const contestSchema = new mongoose.Schema({
 
 contestSchema.plugin(mongoosePaginate)
 
-contestSchema.pre('validate', async function (this: ContestDocument, next) {
+contestSchema.pre('validate', async function (this: ContestDocument) {
   if (this.start >= this.end) {
-    next(new Error('The contest end time must be later than the start time!'))
+    throw new Error('The contest end time must be later than the start time!')
   }
-  next()
 })
-contestSchema.pre('save', async function (this: ContestDocument, next) {
+contestSchema.pre('save', async function (this: ContestDocument) {
   if (this.cid === -1) {
     this.cid = await ID.generateId('Contest')
   }
-  next()
 })
 
 const Contest

backend/src/models/Course.ts

@@ -76,11 +76,10 @@ courseSchema.virtual('canJoin').get(function (this: CourseDocument): boolean {
   return (this.joinCode?.length ?? 0) > 0
 })
 
-courseSchema.pre('save', async function (this: CourseDocument, next) {
+courseSchema.pre('save', async function (this: CourseDocument) {
   if (this.courseId === -1) {
     this.courseId = await ID.generateId('Course')
   }
-  next()
 })
 
 const Course

backend/src/models/Discussion.ts

@@ -31,7 +31,7 @@ const discussionSchema = new mongoose.Schema({
   },
   type: {
     type: Number,
-    enum: DiscussionType,
+    enum: Object.values(DiscussionType).filter((v): v is number => typeof v === 'number'),
     default: DiscussionType.PrivateClarification,
   },
   pinned: {
@@ -58,11 +58,10 @@ const discussionSchema = new mongoose.Schema({
   timestamps: true,
 })
 
-discussionSchema.pre('save', async function (next) {
+discussionSchema.pre('save', async function () {
   if (this.discussionId === -1) {
     this.discussionId = await ID.generateId('Discussion')
   }
-  next()
 })
 
 const Discussion