Skip to content

Commit d6acb22

Browse files
committed
use size-check on worker and not node_modules size
1 parent 0923ee7 commit d6acb22

3 files changed

Lines changed: 2 additions & 11 deletions

File tree

.github/workflows/check_website.yaml

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -45,9 +45,7 @@ jobs:
4545
- name: Vitest tests
4646
run: npm t
4747

48-
# info: https://etok.codes/acmcsuf.com/blob/main/CONTRIBUTING.md#npm-bloat
49-
- name: Test Dependency Size
50-
if: runner.os != 'Windows'
48+
- name: Size Check
5149
run: npm run test:size
5250

5351
- name: Transform Genuary Check Changes

CONTRIBUTING.md

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -52,13 +52,6 @@ npm run host
5252
npm run test:coverage
5353
```
5454

55-
### NPM bloat
56-
57-
In this project, we set a threshold for how large the `/node_modules` folder can become after an `npm install`.
58-
In our [`package.json`](package.json), we set the size to 256 MB.
59-
60-
To test the size of the dependencies in your local workspace, run `npm run test:size`.
61-
6255
## Architecture 🗿
6356

6457
For architecture-related information, please refer to [`ARCHITECTURE.md`](ARCHITECTURE.md).

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@
3434
"preview": "vite build -- mode production && wrangler deploy -e=preview",
3535
"test": "vitest --run",
3636
"test:watch": "vitest",
37-
"test:size": "npm i && size-limit",
37+
"test:size": "npm run build && size-limit",
3838
"test:coverage": "vitest run --coverage",
3939
"check": "svelte-kit sync && svelte-check --tsconfig ./tsconfig.json --compiler-warnings \"css-unused-selector:ignore,unused-export-let:error\"",
4040
"lint": "eslint . --fix",

0 commit comments

Comments
 (0)