Convert stack overflow errors to SyntaxError instances

Issue #1254

Author: marijnh

acorn-loose/src/state.js

@@ -154,7 +154,14 @@ export class LooseParser {
 
   parse() {
     this.next()
-    return this.parseTopLevel()
+    try {
+      return this.parseTopLevel()
+    } catch (e) {
+      if (e instanceof Error && (/\bstack\b.*\b(exceeded|overflow)\b/i.test(e.message) || /\btoo much recursion\b/i.test(e.message)))
+        this.toks.raise(this.toks.start, "Not enough stack space to parse input")
+      else
+        throw e
+    }
   }
 
   static extend(...plugins) {

acorn/src/expression.js

@@ -94,15 +94,17 @@ pp.checkPropClash = function(prop, propHash, refDestructuringErrors) {
 // delayed syntax error at correct position).
 
 pp.parseExpression = function(forInit, refDestructuringErrors) {
-  let startPos = this.start, startLoc = this.startLoc
-  let expr = this.parseMaybeAssign(forInit, refDestructuringErrors)
-  if (this.type === tt.comma) {
-    let node = this.startNodeAt(startPos, startLoc)
-    node.expressions = [expr]
-    while (this.eat(tt.comma)) node.expressions.push(this.parseMaybeAssign(forInit, refDestructuringErrors))
-    return this.finishNode(node, "SequenceExpression")
-  }
-  return expr
+  return this.catchStackOverflow(() => {
+    let startPos = this.start, startLoc = this.startLoc
+    let expr = this.parseMaybeAssign(forInit, refDestructuringErrors)
+    if (this.type === tt.comma) {
+      let node = this.startNodeAt(startPos, startLoc)
+      node.expressions = [expr]
+      while (this.eat(tt.comma)) node.expressions.push(this.parseMaybeAssign(forInit, refDestructuringErrors))
+      return this.finishNode(node, "SequenceExpression")
+    }
+    return expr
+  })
 }
 
 // Parse an assignment expression. This includes applications of

acorn/src/parseutil.js

@@ -59,6 +59,17 @@ pp.eatContextual = function(name) {
   return true
 }
 
+pp.catchStackOverflow = function(f) {
+  try {
+    return f()
+  } catch (e) {
+    if (e instanceof Error && (/\bstack\b.*\b(exceeded|overflow)\b/i.test(e.message) || /\btoo much recursion\b/i.test(e.message)))
+      this.raise(this.start, "Not enough stack space to parse input")
+    else
+      throw e
+  }
+}
+
 // Asserts that following token is given contextual keyword.
 
 pp.expectContextual = function(name) {

acorn/src/state.js

@@ -102,7 +102,7 @@ export class Parser {
   parse() {
     let node = this.options.program || this.startNode()
     this.nextToken()
-    return this.parseTopLevel(node)
+    return this.catchStackOverflow(() => this.parseTopLevel(node))
   }
 
   get inFunction() { return (this.currentVarScope().flags & SCOPE_FUNCTION) > 0 }

test/tests.js

@@ -29968,3 +29968,5 @@ test("foo.if() / 2", {
 })
 
 test("({a: /=/})", {}, {ecmaVersion: 5})
+
+testFail("[".repeat(2000) + "1" + "]".repeat(2000), "~Not enough stack space", {ecmaVersion: "latest"})