Remove phpcompatibility/php-compatibility

Author: TravisCarden

.github/script.sh

@@ -38,7 +38,6 @@ EXPECTED=(
   AcquiaPHPStrict
   Drupal
   DrupalPractice
-  PHPCompatibility
 )
 echo "$INSTALLED"
 for STANDARD in "${EXPECTED[@]}"; do

README.md

@@ -14,7 +14,6 @@ Acquia Coding Standards for PHP includes a selection of sniffs from the followin
 
 * [Drupal Code Sniffer](https://packagist.org/packages/drupal/coder) encapsulates [Drupal coding standards](https://www.drupal.org/coding-standards ) and best practices for module development.
 * [PHP_CodeSniffer](https://packagist.org/packages/squizlabs/php_codesniffer) itself contains several broadly applicable rulesets.
-* [PHPCompatibility](https://github.com/PHPCompatibility/PHPCompatibility) checks for PHP cross-version compatibility with all supported language versions.
 * [Slevomat Coding Standard](https://github.com/slevomat/coding-standard) provides functional (safety and behavior), cleaning (dead code), and formatting (consistent look) sniffs.
 
 ## Rulesets
@@ -39,6 +38,8 @@ There are four permutations of these guidelines, leading to four rulesets to cho
     composer require --dev acquia/coding-standards
     ```
 
+    If you want to add PHP cross-version compatibility checks, we suggest [PHPCompatibility](https://github.com/PHPCompatibility/PHPCompatibility).
+
 1. Inform PHP CodeSniffer of the location of the standard and its dependencies:
 
     * It is strongly recommended that you use a Composer plugin to handle this for you, e.g., [`DealerDirect/phpcodesniffer-composer-installer`](https://github.com/DealerDirect/phpcodesniffer-composer-installer):
@@ -55,7 +56,7 @@ There are four permutations of these guidelines, leading to four rulesets to cho
             "scripts": {
                 "post-install-cmd": "@install-coding-standards",
                 "post-update-cmd" : "@install-coding-standards",
-                "install-coding-standards": "\"vendor/bin/phpcs\" --config-set installed_paths vendor/acquia/coding-standards/src/Standards,vendor/drupal/coder/coder_sniffer,vendor/phpcompatibility/php-compatibility,vendor/slevomat/coding-standard"
+                "install-coding-standards": "\"vendor/bin/phpcs\" --config-set installed_paths vendor/acquia/coding-standards/src/Standards,vendor/drupal/coder/coder_sniffer,vendor/slevomat/coding-standard"
             }
         }
         ```

composer.json

@@ -18,13 +18,13 @@
     ],
     "require": {
         "drupal/coder": "^8.3",
-        "phpcompatibility/php-compatibility": "^10.0.0-alpha1",
         "slevomat/coding-standard": "^8.4",
         "squizlabs/php_codesniffer": "^3.7"
     },
     "suggest": {
         "brainmaestro/composer-git-hooks": "Easily manage Git hooks in your composer config.",
-        "dealerdirect/phpcodesniffer-composer-installer": "Automatically install PHP_CodeSniffer coding standards (rulesets)."
+        "dealerdirect/phpcodesniffer-composer-installer": "Automatically install PHP_CodeSniffer coding standards (rulesets).",
+        "phpcompatibility/php-compatibility": "Check for PHP cross-version compatibility."
     },
     "config": {
         "allow-plugins": {

composer.lock

@@ -13,17 +13,6 @@
     <exclude name="Drupal.Files.TxtFileLineLength.TooLong"/>
   </rule>
 
-  <!-- PHP Compatibility sniffs -->
-  <!-- The lowest version of PHP supported by both Drupal and Acquia Cloud.
-    @see https://www.drupal.org/docs/8/system-requirements/php-requirements
-    @see https://docs.acquia.com/acquia-cloud/arch/tech-platform/
-    For instructions on overriding this value in your project,
-    @see https://github.com/acquia/coding-standards-php/pull/37 -->
-  <config name="testVersion" value="7.4-"/>
-  <rule ref="PHPCompatibility">
-    <exclude name="PHPCompatibility.Extensions.RemovedExtensions.famRemoved"/>
-  </rule>
-
   <!-- Relax rules for automated tests -->
   <rule ref="Drupal.Arrays.Array.LongLineDeclaration">
     <exclude-pattern>tests/*</exclude-pattern>

src/Standards/AcquiaDrupalMinimal/ruleset.xml

@@ -16,17 +16,6 @@
     <exclude-pattern>*.(md|txt|yml)</exclude-pattern>
   </rule>
 
-  <!-- PHP Compatibility sniffs -->
-  <!-- The lowest version of PHP supported by both Drupal and Acquia Cloud.
-    @see https://www.drupal.org/docs/8/system-requirements/php-requirements
-    @see https://docs.acquia.com/acquia-cloud/arch/tech-platform/
-    For instructions on overriding this value in your project,
-    @see https://github.com/acquia/coding-standards-php/pull/37 -->
-  <config name="testVersion" value="7.4-"/>
-  <rule ref="PHPCompatibility">
-    <exclude name="PHPCompatibility.Extensions.RemovedExtensions.famRemoved"/>
-  </rule>
-
   <!-- Apply indentation rules to comments and arrays. -->
   <!-- @see https://github.com/squizlabs/PHP_CodeSniffer/issues/2314 -->
   <!-- @see https://github.com/squizlabs/PHP_CodeSniffer/issues/1235 -->