Skip to content

Commit 731d760

Browse files
committed
Added sql server configuration in CI
1 parent 5edbaf5 commit 731d760

File tree

2 files changed

+22
-1
lines changed

2 files changed

+22
-1
lines changed

.github/workflows/go.yml

Lines changed: 21 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -61,6 +61,27 @@ jobs:
6161
--health-timeout 5s
6262
--health-retries 5
6363
64+
mssql:
65+
image: mcr.microsoft.com/mssql/server:2022-preview-ubuntu-22.04
66+
env:
67+
ACCEPT_EULA: 'Y'
68+
MSSQL_SA_PASSWORD: yourStrong(!)Password
69+
MSSQL_PID: Developer
70+
MSSQL_TCP_PORT: 1433
71+
MSSQL_COLLATION: SQL_Latin1_General_CP1_CI_AS
72+
MSSQL_DB: perfkit_db_ci
73+
MSSQL_USER: perfkit_db_runner
74+
MSSQL_PASSWORD: MyP@ssw0rd123 # example value of a secret compliant with MS SQL Server password policy
75+
ports:
76+
- 1433:1433
77+
# Health check to wait until MSSQL is ready
78+
options: >-
79+
--health-cmd="/opt/mssql-tools/bin/sqlcmd -S localhost -U sa -P yourStrong(!)Password -Q 'SELECT 1' -b -o /dev/null"
80+
--health-interval=10s
81+
--health-timeout=5s
82+
--health-retries=10
83+
--health-start-period=30s
84+
6485
clickhouse:
6586
image: clickhouse/clickhouse-server:24.10-alpine
6687
env:

db/sql/sql_test.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -40,11 +40,11 @@ func TestDatabaseSuiteMySQL(t *testing.T) {
4040
suite.Run(t, &TestingSuite{ConnString: mariaDBConnString})
4141
}
4242

43-
/*
4443
func TestDatabaseSuiteSQLServer(t *testing.T) {
4544
suite.Run(t, &TestingSuite{ConnString: sqlServerConnString})
4645
}
4746

47+
/*
4848
func TestDatabaseSuitePG(t *testing.T) {
4949
suite.Run(t, &TestingSuite{ConnString: postgresqlConnString})
5050
}

0 commit comments

Comments
 (0)