Skip to content

Commit 23cafcc

Browse files
committed
refactor: simplify
Signed-off-by: Pablo Maldonado <[email protected]>
1 parent 5d34e89 commit 23cafcc

File tree

4 files changed

+8
-20
lines changed

4 files changed

+8
-20
lines changed

Diff for: programs/svm-spoke/src/instructions/deposit.rs

+3-3
Original file line numberDiff line numberDiff line change
@@ -12,8 +12,8 @@ use crate::{
1212
event::FundsDeposited,
1313
state::{Route, State},
1414
utils::{
15-
derive_deposit_now_seed_hash, derive_deposit_seed_hash, get_current_time, get_unsafe_deposit_id, transfer_from,
16-
DepositNowSeedData, DepositSeedData,
15+
derive_deposit_seed_hash, get_current_time, get_unsafe_deposit_id, transfer_from, DepositNowSeedData,
16+
DepositSeedData,
1717
},
1818
};
1919

@@ -223,7 +223,7 @@ pub fn deposit_now(
223223
) -> Result<()> {
224224
let state = &mut ctx.accounts.state;
225225
let current_time = get_current_time(state)?;
226-
let seed_hash = derive_deposit_now_seed_hash(
226+
let seed_hash = derive_deposit_seed_hash(
227227
&(DepositNowSeedData {
228228
depositor,
229229
recipient,

Diff for: programs/svm-spoke/src/instructions/fill.rs

+3-3
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ use crate::{
1111
error::{CommonError, SvmError},
1212
event::{FillType, FilledRelay, RelayExecutionEventInfo},
1313
state::{FillRelayParams, FillStatus, FillStatusAccount, State},
14-
utils::{derive_fill_delegate_seed_hash, get_current_time, hash_non_empty_message, invoke_handler, transfer_from},
14+
utils::{derive_fill_seed_hash, get_current_time, hash_non_empty_message, invoke_handler, transfer_from},
1515
};
1616

1717
#[event_cpi]
@@ -32,7 +32,7 @@ pub struct FillRelay<'info> {
3232
)]
3333
pub state: Account<'info, State>,
3434

35-
/// CHECK: PDA derived with seeds ["delegate", fill_delegate_seed_hash]; used as a CPI signer.
35+
/// CHECK: PDA derived with seeds ["delegate", fill_seed_hash]; used as a CPI signer.
3636
pub delegate: UncheckedAccount<'info>,
3737

3838
#[account(
@@ -119,7 +119,7 @@ pub fn fill_relay<'info>(
119119
};
120120

121121
// Verify delegate PDA
122-
let seed_hash = derive_fill_delegate_seed_hash(relay_hash, repayment_chain_id, repayment_address);
122+
let seed_hash = derive_fill_seed_hash(relay_hash, repayment_chain_id, repayment_address);
123123
let (pda, bump) = Pubkey::find_program_address(&[b"delegate", &seed_hash], &ctx.program_id);
124124
if ctx.accounts.delegate.key() != pda {
125125
return err!(SvmError::InvalidDelegatePda);

Diff for: programs/svm-spoke/src/utils/deposit_utils.rs

+1-9
Original file line numberDiff line numberDiff line change
@@ -41,16 +41,8 @@ pub struct DepositNowSeedData {
4141
pub message: Vec<u8>,
4242
}
4343

44-
pub fn derive_seed_hash<T: AnchorSerialize>(seed: &T) -> [u8; 32] {
44+
pub fn derive_deposit_seed_hash<T: AnchorSerialize>(seed: &T) -> [u8; 32] {
4545
let mut buf = Vec::with_capacity(128);
4646
seed.serialize(&mut buf).unwrap();
4747
keccak::hash(&buf).to_bytes()
4848
}
49-
50-
pub fn derive_deposit_seed_hash(args: &DepositSeedData) -> [u8; 32] {
51-
derive_seed_hash(args)
52-
}
53-
54-
pub fn derive_deposit_now_seed_hash(args: &DepositNowSeedData) -> [u8; 32] {
55-
derive_seed_hash(args)
56-
}

Diff for: programs/svm-spoke/src/utils/fill_utils.rs

+1-5
Original file line numberDiff line numberDiff line change
@@ -7,11 +7,7 @@ struct FillDelegateSeedData {
77
repayment_address: Pubkey,
88
}
99

10-
pub fn derive_fill_delegate_seed_hash(
11-
relay_hash: [u8; 32],
12-
repayment_chain_id: u64,
13-
repayment_address: Pubkey,
14-
) -> [u8; 32] {
10+
pub fn derive_fill_seed_hash(relay_hash: [u8; 32], repayment_chain_id: u64, repayment_address: Pubkey) -> [u8; 32] {
1511
let data_struct = FillDelegateSeedData { relay_hash, repayment_chain_id, repayment_address };
1612
let serialized = data_struct.try_to_vec().unwrap();
1713

0 commit comments

Comments
 (0)