Conversation
Signed-off-by: Ihor Farion <ihor@umaproject.org>
Signed-off-by: Ihor Farion <ihor@umaproject.org>
Signed-off-by: Ihor Farion <ihor@umaproject.org>
Signed-off-by: Taylor Webb <tbwebb22@gmail.com>
Signed-off-by: Taylor Webb <tbwebb22@gmail.com>
Signed-off-by: Taylor Webb <tbwebb22@gmail.com>
Signed-off-by: Taylor Webb <tbwebb22@gmail.com>
Signed-off-by: Taylor Webb <tbwebb22@gmail.com>
Signed-off-by: Taylor Webb <tbwebb22@gmail.com>
Signed-off-by: Taylor Webb <tbwebb22@gmail.com>
Signed-off-by: Taylor Webb <tbwebb22@gmail.com>
Signed-off-by: Taylor Webb <tbwebb22@gmail.com>
Signed-off-by: Taylor Webb <tbwebb22@gmail.com>
Signed-off-by: Taylor Webb <tbwebb22@gmail.com>
Signed-off-by: Taylor Webb <tbwebb22@gmail.com>
Signed-off-by: Taylor Webb <tbwebb22@gmail.com>
Signed-off-by: Taylor Webb <tbwebb22@gmail.com>
Signed-off-by: Taylor Webb <tbwebb22@gmail.com>
Signed-off-by: Taylor Webb <tbwebb22@gmail.com>
Signed-off-by: Taylor Webb <tbwebb22@gmail.com>
Signed-off-by: Taylor Webb <tbwebb22@gmail.com>
Signed-off-by: Taylor Webb <tbwebb22@gmail.com>
Signed-off-by: Taylor Webb <tbwebb22@gmail.com>
Signed-off-by: Taylor Webb <tbwebb22@gmail.com>
|
No dependency changes detected. Learn more about Socket for GitHub. 👍 No dependency changes detected in pull request |
Signed-off-by: Taylor Webb <tbwebb22@gmail.com>
Signed-off-by: Taylor Webb <tbwebb22@gmail.com>
…dToken test Signed-off-by: Taylor Webb <tbwebb22@gmail.com>
tbwebb22
commented
Jan 20, 2026
Contributor
Author
There was a problem hiding this comment.
This test had a dependency on constructSimpleTree from the deleted HubPool.ExecuteRootBundle test, so moved that function into here for now
Signed-off-by: Taylor Webb <tbwebb22@gmail.com>
Signed-off-by: Taylor Webb <tbwebb22@gmail.com>
tbwebb22
requested review from
bmzig,
mrice32,
nicholaspai and
pxrl
as code owners
Signed-off-by: Taylor Webb <tbwebb22@gmail.com>
grasphoper
reviewed
Jan 21, 2026
Contributor
There was a problem hiding this comment.
I'm a bit lost RE whether this is needed or if a master merge will fix this
Contributor
Author
There was a problem hiding this comment.
yeah this change certainly isn't intentional from my end
I think if we get this one merged #1262
and then merge master into here, should fix this right?
grasphoper
previously approved these changes
Jan 21, 2026
| // Verify LP token was created (using mock factory, so just verify it's a valid ERC20) | ||
| MintableERC20 lpTokenContract = MintableERC20(lpToken); | ||
| assertTrue(bytes(lpTokenContract.symbol()).length > 0, "LP token should have a symbol"); | ||
| assertTrue(bytes(lpTokenContract.name()).length > 0, "LP token should have a name"); |
Contributor
There was a problem hiding this comment.
Should we also verify the exact name here like the hardhat test was doing?
Signed-off-by: Taylor Webb <tbwebb22@gmail.com>
Signed-off-by: Taylor Webb <tbwebb22@gmail.com>
Signed-off-by: Taylor Webb <tbwebb22@gmail.com>
Signed-off-by: Taylor Webb <tbwebb22@gmail.com>
fusmanii
previously approved these changes
Jan 22, 2026
Contributor
fusmanii
left a comment
fusmanii
left a comment
There was a problem hiding this comment.
Nice work! One minor feedback from claude
1. CLAUDE.md Documentation Mismatch - The doc says FOUNDRY_PROFILE=local but the actual profile name is local-test. This will cause all
revert-message tests to fail if someone follows the docs literally.
Signed-off-by: Taylor Webb <tbwebb22@gmail.com>
Contributor
Author
Good catch! Fixed bd1bda0 |
fusmanii
approved these changes
Jan 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Migrates HubPool tests from Hardhat to Foundry
Closes ACP-20