feat(): Introducing support for DataHub Events Source (#142)

* Wrapping it up

* Adding event source

* Adding more tests

* Adding datahub cloud events source

* Adding prerequisites

* Adding docs

* Addressing gabes comments

* Update hello_world_datahub_cloud.yaml

* Update datahub-actions/src/datahub_actions/plugin/source/acryl/datahub_cloud_event_source.py

Co-authored-by: Gabe Lyons <[email protected]>

* Remove monkeypatched method

---------

Co-authored-by: John Joyce <[email protected]>
Co-authored-by: John Joyce <[email protected]>
Co-authored-by: John Joyce <[email protected]>
Co-authored-by: Gabe Lyons <[email protected]>
Co-authored-by: John Joyce <[email protected]>

Author: 6 people

datahub-actions/setup.py

@@ -127,6 +127,7 @@ def get_long_description():
     "jsonpickle",
     "build",
     "twine",
+    "tenacity",
     *list(
         dependency
         for plugin in [

datahub-actions/src/datahub_actions/cli/actions.py

@@ -17,16 +17,11 @@
 import signal
 import sys
 import time
-import unittest
 from typing import Any, List
 
 import click
 from click_default_group import DefaultGroup
-from datahub.configuration.config_loader import (
-    Environ,
-    _resolve_element,
-    load_config_file,
-)
+from datahub.configuration.config_loader import load_config_file
 
 import datahub_actions as datahub_actions_package
 from datahub_actions.pipeline.pipeline import Pipeline
@@ -39,13 +34,6 @@
 pipeline_manager = PipelineManager()
 
 
-def best_effort_resolve_element(x: str, environ: Environ) -> str:
-    try:
-        return _resolve_element(x, environ=environ)
-    except Exception:
-        return x
-
-
 def pipeline_config_to_pipeline(pipeline_config: dict) -> Pipeline:
     logger.debug(
         f"Attempting to create Actions Pipeline using config {pipeline_config.get('name')}"
@@ -97,17 +85,13 @@ def run(ctx: Any, config: List[str], debug: bool) -> None:
     if config is not None:
         for pipeline_config in config:
             pipeline_config_file = pathlib.Path(pipeline_config)
-            with unittest.mock.patch(
-                "datahub.configuration.config_loader._resolve_element"
-            ) as mock_resolve_element:
-                mock_resolve_element.side_effect = best_effort_resolve_element
-                pipeline_config_dict = load_config_file(pipeline_config_file)
-                enabled = pipeline_config_dict.get("enabled", True)
-                if enabled == "false" or enabled is False:
-                    logger.warning(
-                        f"Skipping pipeline {pipeline_config_dict.get('name')} as it is not enabled"
-                    )
-                    continue
+            pipeline_config_dict = load_config_file(pipeline_config_file)
+            enabled = pipeline_config_dict.get("enabled", True)
+            if enabled == "false" or enabled is False:
+                logger.warning(
+                    f"Skipping pipeline {pipeline_config_dict.get('name')} as it is not enabled"
+                )
+                continue
 
             # now load the config with variable expansion
             pipeline_config_dict = load_config_file(pipeline_config_file)

datahub-actions/src/datahub_actions/plugin/source/acryl/__init__.py

@@ -0,0 +1,2 @@
+PLATFORM_EVENT_TOPIC_NAME = "PlatformEvent_v1"
+ENTITY_CHANGE_EVENT_NAME = "entityChangeEvent"

datahub-actions/src/datahub_actions/plugin/source/acryl/constants.py

@@ -0,0 +1,206 @@
+import json
+import logging
+import time
+from dataclasses import dataclass
+from typing import Iterable, List, Optional
+
+from datahub.configuration import ConfigModel
+from datahub.emitter.serialization_helper import post_json_transform
+
+# DataHub imports.
+from datahub.metadata.schema_classes import GenericPayloadClass
+
+from datahub_actions.event.event_envelope import EventEnvelope
+from datahub_actions.event.event_registry import (
+    ENTITY_CHANGE_EVENT_V1_TYPE,
+    EntityChangeEvent,
+)
+
+# May or may not need these.
+from datahub_actions.pipeline.pipeline_context import PipelineContext
+from datahub_actions.plugin.source.acryl.constants import (
+    ENTITY_CHANGE_EVENT_NAME,
+    PLATFORM_EVENT_TOPIC_NAME,
+)
+from datahub_actions.plugin.source.acryl.datahub_cloud_events_ack_manager import (
+    AckManager,
+)
+from datahub_actions.plugin.source.acryl.datahub_cloud_events_consumer import (
+    DataHubEventsConsumer,
+    ExternalEvent,
+)
+from datahub_actions.source.event_source import EventSource
+
+logging.basicConfig(level=logging.INFO)
+logger = logging.getLogger(__name__)
+
+
+# Converts a DataHub Events Message to an EntityChangeEvent.
+def build_entity_change_event(payload: GenericPayloadClass) -> EntityChangeEvent:
+    try:
+        return EntityChangeEvent.from_json(payload.get("value"))
+    except Exception as e:
+        raise ValueError("Failed to parse into EntityChangeEvent") from e
+
+
+class DataHubEventsSourceConfig(ConfigModel):
+    topic: str = PLATFORM_EVENT_TOPIC_NAME
+    consumer_id: Optional[str]  # Used to store offset for the consumer.
+    lookback_days: Optional[int] = None
+    reset_offsets: Optional[bool] = False
+
+    # Time and Exit Conditions.
+    kill_after_idle_timeout: bool = False
+    idle_timeout_duration_seconds: int = 30
+    event_processing_time_max_duration_seconds: int = 60
+
+
+# This is the custom DataHub-based Event Source.
+@dataclass
+class DataHubEventSource(EventSource):
+    running = False
+    source_config: DataHubEventsSourceConfig
+    ctx: PipelineContext
+
+    @staticmethod
+    def _get_pipeline_urn(pipeline_name: str) -> str:
+        if pipeline_name.startswith("urn:li:dataHubAction:"):
+            return pipeline_name
+        else:
+            return f"urn:li:dataHubAction:{pipeline_name}"
+
+    def __init__(self, config: DataHubEventsSourceConfig, ctx: PipelineContext):
+        self.ctx = ctx
+        self.source_config = config
+        self.consumer_id = DataHubEventSource._get_pipeline_urn(self.ctx.pipeline_name)
+
+        # Ensure a Graph Instance was provided.
+        assert self.ctx.graph is not None
+
+        self.datahub_events_consumer: DataHubEventsConsumer = DataHubEventsConsumer(
+            # TODO: This PipelineContext provides an Acryl Graph Instance
+            graph=self.ctx.graph.graph,
+            consumer_id=self.consumer_id,
+            lookback_days=self.source_config.lookback_days,
+            reset_offsets=self.source_config.reset_offsets,
+        )
+        self.ack_manager = AckManager()
+        self.safe_to_ack_offset: Optional[str] = None
+
+    @classmethod
+    def create(cls, config_dict: dict, ctx: PipelineContext) -> "EventSource":
+        config = DataHubEventsSourceConfig.parse_obj(config_dict)
+        return cls(config, ctx)
+
+    def events(self) -> Iterable[EventEnvelope]:
+        logger.info("Starting DataHub Cloud events source...")
+        logger.info(f"Subscribing to the following topic: {self.source_config.topic}")
+        self.running = True
+        yield from self._poll_and_process_events()
+
+    def _poll_and_process_events(self) -> Iterable[EventEnvelope]:
+        """Poll and process events in the main loop."""
+        last_idle_response_timestamp = 0
+        while self.running:
+            try:
+                sleeps_to_go = (
+                    self.source_config.event_processing_time_max_duration_seconds
+                )
+
+                while self.ack_manager.outstanding_acks():
+                    time.sleep(1)
+                    sleeps_to_go -= 1
+                    logger.debug(f"Sleeps to go: {sleeps_to_go}")
+
+                    if sleeps_to_go == 0:
+                        self.running = False
+                        raise Exception(
+                            f"Failed to process all events successfully after specified time {self.source_config.event_processing_time_max_duration_seconds}! If more time is required, please increase the timeout using this config. {self.ack_manager.acks.values()}",
+                        )
+                logger.debug(
+                    f"Successfully processed events up to offset id {self.safe_to_ack_offset}"
+                )
+                self.safe_to_ack_offset = self.datahub_events_consumer.offset_id
+                logger.debug(f"Safe to ack offset: {self.safe_to_ack_offset}")
+
+                events_response = self.datahub_events_consumer.poll_events(
+                    topic=self.source_config.topic, poll_timeout_seconds=2
+                )
+
+                # Handle Idle Timeout
+                num_events = len(events_response.events)
+
+                if num_events == 0:
+                    if last_idle_response_timestamp == 0:
+                        last_idle_response_timestamp = (
+                            self._get_current_timestamp_seconds()
+                        )
+                    if self._should_idle_timeout(
+                        num_events, last_idle_response_timestamp
+                    ):
+                        logger.info("Exiting main loop due to idle timeout")
+                        return
+                else:
+                    self.ack_manager.new_batch()
+                    last_idle_response_timestamp = 0  # Reset the idle timeout
+
+                event_envelopes: List[EventEnvelope] = []
+                for msg in events_response.events:
+                    for event_envelope in self.handle_pe(msg):
+                        event_envelope.meta = self.ack_manager.get_meta(event_envelope)
+                        event_envelopes.append(event_envelope)
+
+                yield from event_envelopes
+
+            except Exception as e:
+                logger.exception(f"DataHub Events consumer error: {e}")
+                self.running = False
+
+        logger.info("DataHub Events consumer exiting main loop")
+
+    @staticmethod
+    def handle_pe(msg: ExternalEvent) -> Iterable[EventEnvelope]:
+        value: dict = json.loads(msg.value)
+        payload: GenericPayloadClass = GenericPayloadClass.from_obj(
+            post_json_transform(value["payload"])
+        )
+        if ENTITY_CHANGE_EVENT_NAME == value["name"]:
+            event = build_entity_change_event(payload)
+            yield EventEnvelope(ENTITY_CHANGE_EVENT_V1_TYPE, event, {})
+
+    def close(self) -> None:
+        if self.datahub_events_consumer:
+            self.running = False
+            if self.safe_to_ack_offset:
+                self.datahub_events_consumer.commit_offsets(
+                    offset_id=self.safe_to_ack_offset
+                )
+            self.datahub_events_consumer.close()
+
+    def ack(self, event: EventEnvelope, processed: bool = True) -> None:
+        self.ack_manager.ack(event.meta, processed=processed)
+        logger.debug(f"Actions acked event {event} as processed {processed}")
+
+    def _should_idle_timeout(
+        self, num_events: int, last_idle_response_timestamp: int
+    ) -> bool:
+        """Handle idle timeout logic and decide if the loop should exit."""
+        if num_events > 0:
+            return False  # Continue processing
+
+        current_timestamp_seconds = self._get_current_timestamp_seconds()
+
+        if (
+            self.source_config.kill_after_idle_timeout
+            and current_timestamp_seconds - last_idle_response_timestamp
+            > self.source_config.idle_timeout_duration_seconds
+        ):
+            logger.info(
+                f"Shutting down due to idle timeout of {self.source_config.idle_timeout_duration_seconds} seconds"
+            )
+            self.running = False
+            return True  # Signal that we should exit
+        return False  # Continue processing
+
+    def _get_current_timestamp_seconds(self) -> int:
+        return int(time.time())

datahub-actions/src/datahub_actions/plugin/source/acryl/datahub_cloud_event_source.py

@@ -0,0 +1,35 @@
+import logging
+from typing import Any, Dict, Tuple
+
+logger = logging.getLogger(__name__)
+
+
+class AckManager:
+    """
+    An internal Ack manager which hands out fake message ids but ensures we
+    track all acks and processing
+    """
+
+    def __init__(self) -> None:
+        self.batch_id = 0
+        self.msg_id = 0
+        self.acks: Dict[Tuple[int, int], bool] = {}
+
+    def new_batch(self) -> None:
+        self.batch_id += 1
+        self.msg_id = 0
+
+    def get_meta(self, event: Any) -> Dict[str, Any]:
+        self.msg_id += 1
+        self.acks[(self.batch_id, self.msg_id)] = event
+        return {"batch_id": self.batch_id, "msg_id": self.msg_id}
+
+    def ack(self, meta: dict, processed: bool) -> None:
+        batch_id, msg_id = (meta["batch_id"], meta["msg_id"])
+        if processed:
+            self.acks.pop((batch_id, msg_id))
+        else:
+            logger.warning(f"Whoops - we didn't process {meta}")
+
+    def outstanding_acks(self) -> int:
+        return len(self.acks)