Skip to content

Commit 7618af5

Browse files
fix(logging): fixes slow query logging formatting and adds parsing fo… (datahub-project#12955)
Co-authored-by: RyanHolstien <[email protected]>
1 parent 90666ef commit 7618af5

File tree

1 file changed

+14
-2
lines changed

1 file changed

+14
-2
lines changed

datahub-frontend/app/controllers/Application.java

+14-2
Original file line numberDiff line numberDiff line change
@@ -390,19 +390,31 @@ private void logSlowQuery(Http.Request request, String resolvedUri, float durati
390390
Optional<Cookie> actorCookie = request.getCookie("actor");
391391
String actorValue = actorCookie.isPresent() ? actorCookie.get().value() : "N/A";
392392

393+
// Get the JSON body
393394
try {
394395
ObjectMapper mapper = new ObjectMapper();
395396
JsonNode jsonNode = request.body().asJson();
396397
((ObjectNode) jsonNode).remove("query");
397-
jsonBody.append(mapper.writerWithDefaultPrettyPrinter().writeValueAsString(jsonNode));
398+
jsonBody.append(mapper.writeValueAsString(jsonNode));
398399
} catch (Exception e) {
399400
logger.info("GraphQL Request Received: {}, Unable to parse JSON body", resolvedUri);
400401
}
401402
String jsonBodyStr = jsonBody.toString();
403+
404+
// Get the query string
405+
StringBuilder query = new StringBuilder();
406+
try {
407+
ObjectMapper mapper = new ObjectMapper();
408+
query.append(mapper.writeValueAsString(request.queryString()));
409+
} catch (Exception e) {
410+
logger.info("GraphQL Request Received: {}, Unable to parse query string", resolvedUri);
411+
}
412+
String queryString = query.toString();
413+
402414
logger.info(
403415
"Slow GraphQL Request Received: {}, Request query string: {}, Request actor: {}, Request JSON: {}, Request completed in {} ms",
404416
resolvedUri,
405-
request.queryString(),
417+
queryString,
406418
actorValue,
407419
jsonBodyStr,
408420
duration);

0 commit comments

Comments
 (0)