Commit 13648c5
committed
feat(cli): L1 phase C1 — per-op filesystem policy with virtual-root preopen
Custom HostDescriptor impl gates every path-taking wasi:filesystem
operation on the compiled FsMatcher. Delivers the deny-overlay case
that preopen-only enforcement couldn't — user can write
--fs-allow '~/projects/**' --fs-deny '~/.ssh/**' and the guest sees
the former but opens in the latter get NotPermitted at the WASI layer.
Design:
- Single virtual-root preopen at host / for every non-Deny mode. The
guest sees the whole host fs in its namespace but can't open anything
the matcher denies. FsConfig::preopens() returns an empty list (Deny)
or [{guest: /, host: /}] (Allowlist or Open).
- FsMatcher (new fs_matcher.rs, globset-based) compiles allow/deny
patterns. Full glob syntax: *, ?, [...], {a,b}, **, trailing / or /**
for directory subtrees. Literal directory patterns implicitly also
match descendants.
- PolicyFilesystem (new fs_policy.rs) is a HasData marker used to
shadow the default wasi:filesystem/types and /preopens bindings.
PolicyFilesystemCtxView holds ctx, table, matcher, and a
fd -> host path map populated at get-directories time and updated
on every open-at.
- Path-taking methods (open_at, stat_at, create_directory_at,
remove_directory_at, unlink_file_at, rename_at, link_at, symlink_at,
readlink_at, metadata_hash_at, set_times_at) look up the parent fd's
host path, join the rel path, normalise .. and consult the matcher.
Non-path methods (read, write, stat on a handle, stream setup, etc.)
delegate unchanged.
Known limitations:
- Unix-first. Preopening host / assumes a POSIX root; Windows needs
per-drive preopens (future work).
- p3 wasi:filesystem bindings are not yet shadowed; wasip3
filesystem-using components bypass the matcher. Components target
wasm32-wasip2 today.
- Symlink resolution and TOCTOU: the matcher operates on the
guest-supplied path before cap-std opens the target. cap-std's *at
syscalls prevent .. escape within the preopen, but a symlink that
points outside an allowed subtree would resolve through cap-std's
default policy (still scoped to /).
Removes the earlier 'fs.deny is parsed but not enforced' warning -
deny entries are now enforced via the matcher. Removes path_to_mount /
literal_prefix logic - no longer needed with the single-virtual-root
preopen.
Verified end-to-end with the filesystem component:
- --fs-allow /tmp/x + read /tmp/x/foo: works
- --fs-allow /tmp/x + read /etc/passwd: Permission denied
- --fs-allow '/tmp/x/**' --fs-deny /tmp/x/secret.txt: reads
/tmp/x/allowed.txt, denies /tmp/x/secret.txt
std:fs:mount-root is respected via apply_mount_root - rewrites the
guest-facing path of the virtual root preopen (guest sees {mount-root}
instead of /). Policy matching always on host paths.1 parent ed0411c commit 13648c5
7 files changed
Lines changed: 728 additions & 69 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
50 | 50 | | |
51 | 51 | | |
52 | 52 | | |
| 53 | + | |
53 | 54 | | |
54 | 55 | | |
55 | 56 | | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
55 | 55 | | |
56 | 56 | | |
57 | 57 | | |
58 | | - | |
59 | | - | |
60 | | - | |
61 | | - | |
| 58 | + | |
| 59 | + | |
| 60 | + | |
| 61 | + | |
| 62 | + | |
| 63 | + | |
| 64 | + | |
| 65 | + | |
| 66 | + | |
62 | 67 | | |
63 | 68 | | |
64 | 69 | | |
65 | | - | |
| 70 | + | |
66 | 71 | | |
67 | 72 | | |
68 | 73 | | |
69 | | - | |
70 | 74 | | |
71 | 75 | | |
72 | 76 | | |
| |||
206 | 210 | | |
207 | 211 | | |
208 | 212 | | |
209 | | - | |
210 | | - | |
211 | | - | |
212 | | - | |
213 | | - | |
214 | | - | |
215 | | - | |
216 | | - | |
217 | | - | |
218 | | - | |
219 | | - | |
220 | | - | |
221 | | - | |
222 | | - | |
223 | | - | |
224 | | - | |
225 | | - | |
226 | | - | |
227 | | - | |
228 | | - | |
229 | | - | |
230 | | - | |
231 | | - | |
232 | | - | |
233 | | - | |
234 | | - | |
235 | 213 | | |
236 | 214 | | |
237 | 215 | | |
| |||
444 | 422 | | |
445 | 423 | | |
446 | 424 | | |
| 425 | + | |
447 | 426 | | |
448 | 427 | | |
449 | 428 | | |
450 | | - | |
| 429 | + | |
451 | 430 | | |
452 | 431 | | |
453 | | - | |
| 432 | + | |
454 | 433 | | |
455 | 434 | | |
456 | 435 | | |
| 436 | + | |
457 | 437 | | |
458 | | - | |
459 | | - | |
460 | | - | |
461 | | - | |
462 | | - | |
463 | | - | |
464 | | - | |
465 | | - | |
466 | | - | |
467 | | - | |
468 | | - | |
469 | | - | |
470 | | - | |
471 | | - | |
472 | | - | |
473 | | - | |
474 | | - | |
475 | | - | |
476 | | - | |
477 | | - | |
478 | | - | |
479 | | - | |
| 438 | + | |
| 439 | + | |
480 | 440 | | |
481 | 441 | | |
482 | 442 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
| 34 | + | |
| 35 | + | |
| 36 | + | |
| 37 | + | |
| 38 | + | |
| 39 | + | |
| 40 | + | |
| 41 | + | |
| 42 | + | |
| 43 | + | |
| 44 | + | |
| 45 | + | |
| 46 | + | |
| 47 | + | |
| 48 | + | |
| 49 | + | |
| 50 | + | |
| 51 | + | |
| 52 | + | |
| 53 | + | |
| 54 | + | |
| 55 | + | |
| 56 | + | |
| 57 | + | |
| 58 | + | |
| 59 | + | |
| 60 | + | |
| 61 | + | |
| 62 | + | |
| 63 | + | |
| 64 | + | |
| 65 | + | |
| 66 | + | |
| 67 | + | |
| 68 | + | |
| 69 | + | |
| 70 | + | |
| 71 | + | |
| 72 | + | |
| 73 | + | |
| 74 | + | |
| 75 | + | |
| 76 | + | |
| 77 | + | |
| 78 | + | |
| 79 | + | |
| 80 | + | |
| 81 | + | |
| 82 | + | |
| 83 | + | |
| 84 | + | |
| 85 | + | |
| 86 | + | |
| 87 | + | |
| 88 | + | |
| 89 | + | |
| 90 | + | |
| 91 | + | |
| 92 | + | |
| 93 | + | |
| 94 | + | |
| 95 | + | |
| 96 | + | |
| 97 | + | |
| 98 | + | |
| 99 | + | |
| 100 | + | |
| 101 | + | |
| 102 | + | |
| 103 | + | |
| 104 | + | |
| 105 | + | |
| 106 | + | |
| 107 | + | |
| 108 | + | |
| 109 | + | |
| 110 | + | |
| 111 | + | |
| 112 | + | |
| 113 | + | |
| 114 | + | |
| 115 | + | |
| 116 | + | |
| 117 | + | |
| 118 | + | |
| 119 | + | |
| 120 | + | |
| 121 | + | |
| 122 | + | |
| 123 | + | |
| 124 | + | |
| 125 | + | |
| 126 | + | |
| 127 | + | |
| 128 | + | |
| 129 | + | |
| 130 | + | |
| 131 | + | |
| 132 | + | |
| 133 | + | |
| 134 | + | |
| 135 | + | |
| 136 | + | |
| 137 | + | |
| 138 | + | |
| 139 | + | |
| 140 | + | |
| 141 | + | |
| 142 | + | |
| 143 | + | |
| 144 | + | |
| 145 | + | |
| 146 | + | |
| 147 | + | |
| 148 | + | |
| 149 | + | |
| 150 | + | |
| 151 | + | |
| 152 | + | |
| 153 | + | |
| 154 | + | |
| 155 | + | |
| 156 | + | |
| 157 | + | |
| 158 | + | |
| 159 | + | |
| 160 | + | |
| 161 | + | |
| 162 | + | |
| 163 | + | |
| 164 | + | |
| 165 | + | |
| 166 | + | |
| 167 | + | |
| 168 | + | |
| 169 | + | |
| 170 | + | |
| 171 | + | |
| 172 | + | |
| 173 | + | |
| 174 | + | |
| 175 | + | |
| 176 | + | |
| 177 | + | |
| 178 | + | |
| 179 | + | |
| 180 | + | |
| 181 | + | |
| 182 | + | |
| 183 | + | |
| 184 | + | |
| 185 | + | |
| 186 | + | |
| 187 | + | |
| 188 | + | |
| 189 | + | |
| 190 | + | |
| 191 | + | |
| 192 | + | |
| 193 | + | |
| 194 | + | |
| 195 | + | |
| 196 | + | |
| 197 | + | |
| 198 | + | |
| 199 | + | |
| 200 | + | |
| 201 | + | |
| 202 | + | |
| 203 | + | |
| 204 | + | |
| 205 | + | |
| 206 | + | |
| 207 | + | |
| 208 | + | |
| 209 | + | |
| 210 | + | |
| 211 | + | |
| 212 | + | |
| 213 | + | |
| 214 | + | |
0 commit comments