Skip to content

Git error from bad filenames on windows not revealed if persist-credentials is false #2037

Open
@CoolCat467

Description

If persist-credentials is set to false and there is a file in the repository with a filename windows doesn't like (eg contains colon(s)), error removing authentication and no indication that error is resulting from bad filename:

Checking out the ref
Removing auth
  "C:\Program Files\Git\bin\git.exe" config --local --name-only --get-regexp core\.sshCommand
  "C:\Program Files\Git\bin\git.exe" submodule foreach --recursive "sh -c \"git config --local --name-only --get-regexp 'core\.sshCommand' && git config --local --unset-all 'core.sshCommand' || :\""
  "C:\Program Files\Git\bin\git.exe" config --local --name-only --get-regexp http\.https\:\/\/github\.com\/\.extraheader
  http.https://github.com/.extraheader
  "C:\Program Files\Git\bin\git.exe" config --local --unset-all http.https://github.com/.extraheader
  "C:\Program Files\Git\bin\git.exe" submodule foreach --recursive "sh -c \"git config --local --name-only --get-regexp 'http\.https\:\/\/github\.com\/\.extraheader' && git config --local --unset-all 'http.https://github.com/.extraheader' || :\""
Error: The process 'C:\Program Files\Git\bin\git.exe' failed with exit code 128

but when persist-credentials is true, root problem is revealed:

Checking out the ref
  "C:\Program Files\Git\bin\git.exe" checkout --progress --force -B event-driven refs/remotes/origin/event-driven
  Error: error: invalid path 'src/azul/screenshots/Crash_at_Wed-Nov-13-15:30:42-2024.png'
  Error: The process 'C:\Program Files\Git\bin\git.exe' failed with exit code 128

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions