Skip to content

Github runner application exit code is not propagated via launcher  #2769

Open
@mattem

Description

Describe the bug
The wrapper script for Runner.Listener does not propagate the exit code when invoked, and always exists 0.
This makes it impossible for any systemd unit error handling to correctly handle the runner exit status.

Submitted a fix here, #2719 but it has not had any attention in over three weeks.

To Reproduce
Steps to reproduce the behavior:

  1. Force the runner listener process to exit non-zero (I did this via an invalid registration)
  2. Allow any retries to exhaust.
  3. Check the exit code of the process, note that it is 0.

Expected behavior
The error code is propagated to the caller.

Runner Version and Platform

Version of your runner?
v2.308.0

OS of the machine running the runner? OSX/Windows/Linux/...
Linux

What's not working?

N/A

Job Log Output

N/A

Runner and Worker's Diagnostic Logs

N/A

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't workingkeepLabel can be added as soon as we are sure the work on the issue is necessary

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions